Fixed bug with gpio output mode setting

gpio push pull output mode setting was incorrect, causing random resets

Author: gpgreen

CHANGELOG.md

@@ -2,7 +2,13 @@
 
 All notable changes to this project will be documented in this file.
 
-## v0.2.0
+## v0.2.1 - 2025-02-04
+
+### Fixed
+
+- Fixed bug with gpio mode setting for output push pull vs open drain, causing hardware resets.
+
+## v0.2.0 - 2025-01-21
 
 This version depends on py32-rs v0.2.0 or later
 
@@ -80,11 +86,11 @@ This version depends on py32-rs v0.2.0 or later
 - Fixed github action `ci.yml`
 - Fixed `tool/check.py`
 
-## v0.1.1 - 2024-10-10
+## v0.1.1 - 2024-10-10 - 2024-10-10
 
-## V0.1.0 - 2024-09-07
+## V0.1.0 - 2024-09-07 - 2024-09-07
 
-## v0.0.1 - 2023-06-10
+## v0.0.1 - 2023-06-10 - 2023-06-10
 
  - Original Release
 

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "py32f0xx-hal"
-version = "0.2.0"
+version = "0.2.1"
 authors = [
     "creatoy@yeah.net",
     "Greg Green <ggreen@bit-builder.com>",
@@ -23,7 +23,7 @@ targets = ["thumbv6m-none-eabi"]
 bare-metal = { version = "1.0.0" }
 cast = "0.3.0"
 cortex-m = { version = "0.7.7", features = ["critical-section-single-core"] }
-py32f0 = "0.2.0"
+py32f0 = "= 0.2.0"
 embedded-hal = "1.0"
 embedded-hal-nb = "1.0"
 embedded-dma = "0.2.0"

README.md

@@ -43,7 +43,7 @@ cortex-m = "0.7.7"
 cortex-m-rt = "0.7.3"
 # Panic behaviour, see https://crates.io/keywords/panic-impl for alternatives
 panic-halt = "0.2.0"
-py32f0xx-hal = { version = "0.2.0", features = ["py32f002ax5"]}
+py32f0xx-hal = { version = "0.2.1", features = ["py32f002ax5"]}
 ```
 
 If you are unfamiliar with embedded development using Rust, there are a number of fantastic resources available to help.

src/gpio.rs

@@ -1073,12 +1073,12 @@ impl<const P: char, const N: u8, M> Pin<P, N, M> {
         };
         // if an output, set output type
         if MODE::MODE == Mode::Output {
-            let otyperv = if MODE::CNF == Cnf::OpenDrain {
-                0b1 << N
-            } else {
-                !(0b1 << N)
+            let otv = match MODE::CNF {
+                Cnf::OpenDrain => 0b1,
+                Cnf::PushPull => 0b0,
             };
-            unsafe { gpio.otyper.modify(|r, w| w.bits(r.bits() | otyperv)) };
+            gpio.otyper
+                .modify(|r, w| unsafe { w.bits((r.bits() & !(0b1 << N)) | (otv << N)) });
         }
         // if an alternate function pin, set that
         if let Some(af) = MODE::AF {