Skip to content

Commit 2a1b584

Browse files
authored
Merge pull request #1 from serinlee1065/dev
Pulling dev
2 parents 06e5ef9 + c5fa00d commit 2a1b584

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

57 files changed

+11176
-2256
lines changed

.github/scripts/update_version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
patch_number = line_split[2].split("'")[0].split('"')[0]
1212

1313
# Increment patch number
14-
patch_number = str(int(patch_number) + 1) + "'"
14+
patch_number = str(int(patch_number) + 1) + '"\n'
1515

1616

1717
new_line = line_split[0] + "." + line_split[1] + "." + patch_number

.github/workflows/linter.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
fetch-depth: 0
1818

1919
- name: Lint Code Base
20-
uses: github/super-linter@v5
20+
uses: github/super-linter@v7
2121
env:
2222
VALIDATE_ALL_CODEBASE: false
2323
VALIDATE_PYTHON_FLAKE8: true

.github/workflows/pypi_upload.yml

Lines changed: 0 additions & 85 deletions
This file was deleted.

CONTRIBUTORS.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,11 @@ There are many ways to contribute to py4DSTEM, including:
2020

2121
### Coding Guidelines
2222

23-
* **Code style:** py4DSTEM uses the black code formatter and flake8 linter. All code must pass these checks without error before it can be merged. We suggest using `pre-commit` to help ensure any code commited follows these practices, checkout the [setting up developer environment section below](#install). We also try to abide by PEP8 coding style guide where possible.
23+
* **Code style:** py4DSTEM uses the black code formatter and flake8 linter. All code must pass these checks without error before it can be merged. We suggest using `pre-commit` to help ensure any code committed follows these practices, checkout the [setting up developer environment section below](#install). We also try to abide by PEP8 coding style guide where possible.
2424

2525
* **Documentation:** All code should be well-documented, and use Numpy style docstrings. Use docstrings to document functions and classes, add comments to explain complex code both blocks and individual lines, and use informative variable names.
2626

27-
* **Testing:** Ideally all new code should be accompanied by tests using pyTest framework; at the least we require examples of old and new behaviour caused by the PR. For bug fixes this can be a block of code which currently fails and works with the proposed changes. For new workflows or extensive feature additions, please also include a Jupyter notebook demonstrating the changes for an entire workflow i.e. from loading the input data to visualizing and saving any processed results.
27+
* **Testing:** Ideally all new code should be accompanied by tests using pyTest framework; at the least we require examples of old and new behaviour caused by the PR. For bug fixes this can be a block of code which currently fails and works with the proposed changes. For new workflows or extensive feature additions, please also include a Jupyter notebook demonstrating the changes for an entire workflow i.e. from loading the input data to visualizing and saving any processed results.
2828

2929
* **Dependencies:** New dependencies represent a significant change to the package, and any PRs which add new dependencies will require discussion and agreement from the development team. If a new dependency is required, please prioritize adding dependencies that are actively maintained, have permissive installation requirements, and are accessible through both pip and conda.
3030

@@ -107,20 +107,20 @@ You can now make changes to the code and test them using your favorite Python ID
107107
cd <path-to-your-fork-of-the-py4DSTEM-git-repo> # go to your py4DSTEM repo
108108
pre-commit install
109109
```
110-
110+
111111
This will setup pre-commit to work on this repo by creating/changing a file in .git/hooks/pre-commit, which tells `pre-commit` to automatically run flake8 and black when you try to commit code. It won't affect any other repos.
112112
113-
**_extra tips_:**
113+
**_extra tips_:**
114114
115115
```bash
116116
# You can call pre commit manually at any time without committing
117-
pre-commit run # will check any staged files
117+
pre-commit run # will check any staged files
118118
pre-commit run -a # will run on all files in repo
119119
120-
# you can bypass the hook and commit files without the checks
120+
# you can bypass the hook and commit files without the checks
121121
# (this isn't best practice and should be avoided, but there are times it can be useful)
122122

123-
git add file # stage file as usual
123+
git add file # stage file as usual
124124
git commit -m "you commit message" --no-verify # commit without running checks
125-
git push # push to repo.
125+
git push # push to repo.
126126
```

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ this is a test --
33

44
> :warning: **py4DSTEM version 0.14 update** :warning: Warning: this is a major update and we expect some workflows to break. You can still install previous versions of py4DSTEM [as discussed here](#legacyinstall)
55
6-
> :warning: **Phase retrieval refactor version 0.14.9** :warning: Warning: The phase-retrieval modules in py4DSTEM (DPC, parallax, and ptychography) underwent a major refactor in version 0.14.9 and as such older tutorial notebooks will not work as expected. Notably, class names have been pruned to remove the trailing "Reconstruction" (`DPCReconstruction` -> `DPC` etc.), and regularization functions have dropped the `_iter` suffix (and are instead specified as boolean flags). We are working on updating the tutorial notebooks to reflect these changes. In the meantime, there's some more information in the relevant pull request [here](https://github.com/py4dstem/py4DSTEM/pull/597#issuecomment-1890325568).
6+
> :warning: **Phase retrieval refactor version 0.14.9** :warning: Warning: The phase-retrieval modules in py4DSTEM (DPC, parallax, and ptychography) underwent a major refactor in version 0.14.9 and as such older tutorial notebooks will not work as expected. Notably, class names have been pruned to remove the trailing "Reconstruction" (`DPCReconstruction` -> `DPC` etc.), and regularization functions have dropped the `_iter` suffix (and are instead specified as boolean flags). See the [updated tutorials](https://github.com/py4dstem/py4DSTEM_tutorials) for more information.
77
88
![py4DSTEM logo](/images/py4DSTEM_logo.png)
99

0 commit comments

Comments
 (0)