`ppdzmin` and `pphmax` should be optional

[malmans2]

ppdzmin is not used for uniform grids, so I think it should become an optional argument.
@oceandie what do you think?

[malmans2]

Actually, I think pphmax as well is not necessarily used? For example when the grid is not uniform and ppsur, ppa0, ppa1 are not computed?

[oceandie]

For ppdzmin I agree. For pphmax no, it is used also for uniform grids, see here

[malmans2]

Maybe I'm just getting confused, but I think that if grid is NOT uniform and ppsur, ppa0, ppa1 are specified, pphmax is not used.
I.e., in that scenario the user would have to assign a dummy value to pphmax

[malmans2]

For example, in our ORCA2 test you can assign any value to ppdzmin and pphmax and the test will pass

pyDOMCFG/pydomcfg/tests/test_zco.py

Lines 32 to 42 in f68612d

	dsz_an = ds_bathy.domcfg.zco(
	ppdzmin=10.0,
	pphmax=5000.0,
	ppkth=21.43336197938,
	ppacr=3,
	ppsur=-4762.96143546300,
	ppa0=255.58049070440,
	ppa1=245.58132232490,
	ldbletanh=False,
	ln_e3_dep=False,
	)

[oceandie]

Maybe I'm just getting confused, but I think that if grid is NOT uniform and ppsur, ppa0, ppa1 are specified, pphmax is not used.
I.e., in that scenario the user would have to assign a dummy value to pphmax

Yes, in the case ppsur, ppa0, ppa1 are specified (computed) pphmax is not used. Sorry, I didn't understand what you meant before with 'ppsur, ppa0, ppa1 are not computed' .