File tree Expand file tree Collapse file tree 2 files changed +8
-13
lines changed
Expand file tree Collapse file tree 2 files changed +8
-13
lines changed Original file line number Diff line number Diff line change 1414
1515# TODO: if we export files we might want packages.yml and then under_review.yml
1616# thus we'd want to add a second input parameters which was file_name
17- # TODO: feature - Would be cool to create an "under review now" list as well -
18- # ideally this could be passed as a CLI argument with the label we want to
19- # search for
17+ # TODO: feature - Create an "under review now" list as well
2018
2119import pickle
2220
@@ -35,9 +33,7 @@ def main():
3533 # Get all issues for approved packages - load as dict
3634 issues = process_review .return_response ()
3735 # TODO: this method parse_issue_header is working but the parsing code is
38- # really hard to follow
39- # It is worth another pr that cleans up the workflow around grabbing
40- # metadata so it's clearer to follow.
36+ # hard to follow
4137 accepted_reviews = process_review .parse_issue_header (issues , 45 )
4238
4339 # Update gh metrics via api for all packages
@@ -47,7 +43,6 @@ def main():
4743 )
4844
4945 # Populate model objects with review data + metrics
50- # TODO: all_reviews contains a bunch of extra mess that it doesn't need
5146 final_reviews = {}
5247 for key , review in all_reviews .items ():
5348 # First add gh meta to each dict
Original file line number Diff line number Diff line change @@ -458,15 +458,15 @@ def parse_issue_header(
458458 body_data , "## Scope" , 10
459459 )
460460 # NOTE: right now the numeric value is hard coded based on the
461- # number of partners listed in the issue. so it assumes there is
462- # 3 partners. but that might not always be the case so we should
463- # add a check in case there are fewer or more partners (if someone
464- # modifies the template which they tend to do OR if it's an older
465- # template)
466- # TODO: rather than exact match have the line start_with the string
461+ # number of categories listed in the issue template.
462+ # this could be made more flexible if it just runs until it runs
463+ # out of categories to parse
467464 review [pkg_name ]["partners" ] = self .get_categories (
468465 body_data , "## Community Partnerships" , 3
469466 )
467+ # TODO: the current workflow will not parse domains
468+ # add a separate workflow to parse domains and add them to the
469+ # categories list
470470 # review[pkg_name]["domains"] = self.get_categories(body_data,
471471 # '## Domains',
472472 # 3)
You can’t perform that action at this time.
0 commit comments