Skip to content

Commit 8d3e9a3

Browse files
willingclwasser
authored andcommitted
Fix codacy style suggestions
1 parent df9e464 commit 8d3e9a3

File tree

2 files changed

+50
-50
lines changed

2 files changed

+50
-50
lines changed

CONTRIBUTING.md

Lines changed: 46 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -13,17 +13,17 @@ To run this script, you can call the following at the command line:
1313
This script parses data from all-contributors bot `.json`
1414
files in the following repos:
1515

16-
- [software-submission repo](https://github.com/pyOpenSci/software-submission) where peer review happens
17-
- [python-package-guide repo](https://github.com/pyOpenSci/python-package-guide)
18-
- [peer review guide repo](https://github.com/pyOpenSci/software-peer-review)
19-
- [pyopensci.github.io (website) repo](https://github.com/pyOpenSci/pyopensci.github.io)
20-
- [update-package-meta repo](https://github.com/pyOpenSci/update-web-metadata) _(this repo)_
16+
- [software-submission repo](https://github.com/pyOpenSci/software-submission) where peer review happens
17+
- [python-package-guide repo](https://github.com/pyOpenSci/python-package-guide)
18+
- [peer review guide repo](https://github.com/pyOpenSci/software-peer-review)
19+
- [pyopensci.github.io (website) repo](https://github.com/pyOpenSci/pyopensci.github.io)
20+
- [update-package-meta repo](https://github.com/pyOpenSci/update-web-metadata) _(this repo)_
2121

2222
Running this script:
2323

24-
1. Parses through all of the all-contributors bot `.json` files across our pyOpenSci repos to gather contributors to our organization. This allows us to [acknowledge contributors on our website](https://www.pyopensci.org/our-community/#pyopensci-community-contributors) who are not always making explicit code contributions (thus might not have commits). These contributors are reviewing guidebooks, participating in peer review, and performing other important tasks that are critical to our pyOpenSci mission. We acknowledge all contributions at pyOpenSci regardless of volume or size.
25-
2. Updates the existing [contributors.yml](https://github.com/pyOpenSci/pyopensci.github.io/blob/main/_data/contributors.yml) file found in our website repo with new contributors and the contributor role (package guides, code workflows, peer review, etc).
26-
a. If you run the script using `--update update_all`, this script will also use the GitHub api to update the users metadata from their GitHub profile.
24+
1. Parses through all of the all-contributors bot `.json` files across our pyOpenSci repos to gather contributors to our organization. This allows us to [acknowledge contributors on our website](https://www.pyopensci.org/our-community/#pyopensci-community-contributors) who are not always making explicit code contributions (thus might not have commits). These contributors are reviewing guidebooks, participating in peer review, and performing other important tasks that are critical to our pyOpenSci mission. We acknowledge all contributions at pyOpenSci regardless of volume or size.
25+
2. Updates the existing [contributors.yml](https://github.com/pyOpenSci/pyopensci.github.io/blob/main/_data/contributors.yml) file found in our website repo with new contributors and the contributor role (package guides, code workflows, peer review, etc).
26+
If you run the script using `--update update_all`, this script will also use the GitHub api to update the users metadata from their GitHub profile.
2727

2828
## update-reviews script
2929

@@ -33,9 +33,9 @@ To run this script, you can call the following at the command line:
3333

3434
This script parses through our (_accepted_) review issues to find packages that have been accepted. It then grabs each reviews editor, reviewers and package authors / maintainers. This information allows us to
3535

36-
1. Update a contributor's peer review metadata in the contributors.yml file in the third script.
37-
2. Update the pyOpenSci website's package listing with the package's DOI, documentation URL.
38-
3. Update the package's stats including stars, contributors, etc. using the GitHub API
36+
1. Update a contributor's peer review metadata in the contributors.yml file in the third script.
37+
2. Update the pyOpenSci website's package listing with the package's DOI, documentation URL.
38+
3. Update the package's stats including stars, contributors, etc. using the GitHub API
3939

4040
## process_reviews.py script
4141

@@ -46,28 +46,28 @@ To run this script, you can call the following at the command line:
4646
This final script is a bridge between the first it uses pickle files outputted from the
4747
first two scripts to update each contributors peer review contributions including
4848

49-
1. packages submitted or reviewed
50-
2. packages in which the contributor served as editors
51-
3. contributor types associated with peer review including:
49+
1. packages submitted or reviewed
50+
2. packages in which the contributor served as editors
51+
3. contributor types associated with peer review including:
5252

53-
- peer-review
54-
- package-maintainer
55-
- package-reviewer
56-
- package-editor
53+
- peer-review
54+
- package-maintainer
55+
- package-reviewer
56+
- package-editor
5757

5858
These general contributor types are used to drive our [website's
5959
contributor search and filter functionality that you can see here.](https://www.pyopensci.org/our-community/index.html#pyopensci-community-contributors)
6060

6161
## Local setup
6262

63-
1. Create a local environment and activate it. If you are using conda:
63+
1. Create a local environment and activate it. If you are using conda:
6464

6565
```bash
6666
mamba create -n pyos-meta python=3.10
6767
mamba activate pyos-meta
6868
```
6969

70-
2. Install the package in editable mode and associated development dependencies:
70+
2. Install the package in editable mode and associated development dependencies:
7171

7272
```
7373
pip install -e ".[dev]"
@@ -80,8 +80,8 @@ API.](https://docs.github.com/en/rest/guides/getting-started-with-the-rest-api?a
8080

8181
After obtaining a token;
8282

83-
1. Duplicate the `.env-default` file and rename the copy to `.env`
84-
2. Assign your token to the `GITHUB_TOKEN` variable in the `.env` file.
83+
1. Duplicate the `.env-default` file and rename the copy to `.env`
84+
2. Assign your token to the `GITHUB_TOKEN` variable in the `.env` file.
8585

8686
## How to run each script
8787

@@ -96,44 +96,44 @@ To run:
9696

9797
The `update-contributors` script does the following:
9898

99-
1. It grabs the `all-contribs.json` files from each repository and turns that json data into a dictionary of all unique contributors across repos. Repos include:
100-
- peer review guide
101-
- packaging guide
102-
- website
103-
- software-review
104-
- update-package-meta (this repo)
105-
2. It then:
99+
1. It grabs the `all-contribs.json` files from each repository and turns that json data into a dictionary of all unique contributors across repos. Repos include:
100+
- peer review guide
101+
- packaging guide
102+
- website
103+
- software-review
104+
- update-package-meta (this repo)
105+
2. It then:
106106

107107
If you use the `--update update_all` flag, it will:
108108

109-
- Update contrib profile information including name using whatever information is available their public github
110-
account for website, location, organization, twitter, etc).
111-
- Check to see that the website in their profile works, if not removes it so it doesn't begin to fail our website ci tests.
109+
- Update contrib profile information including name using whatever information is available their public github
110+
account for website, location, organization, twitter, etc).
111+
- Check to see that the website in their profile works, if not removes it so it doesn't begin to fail our website ci tests.
112112

113113
Without the `update` flag, running `update-contributors` will only add any new users that
114114
are not already in the website `contributors.yml` file to a output `.pickle` file.
115115

116116
### update-reviews Returns:
117117

118-
- `all-contributors.pickle` file that will be used in the final update-reviewers script to update all reviewer contribution data.
118+
- `all-contributors.pickle` file that will be used in the final update-reviewers script to update all reviewer contribution data.
119119

120120
## update-reviews script
121121

122122
To run:
123123
`update-reviews` or
124124
`update-reviews --update update_all`
125125

126-
- This script parses through all pyOpenSci issues in the [software-submissions repo](https://github.com/pyOpenSci/software-submission) issues where the issue has a label of 6/`pyOS-approved 🚀🚀🚀`.
127-
- Grabs crucial metadata including the reviewers and editors for each.
128-
- Adds people who have participated in peer review who are NOT listed currently in the website `contributors.yml` file
126+
- This script parses through all pyOpenSci issues in the [software-submissions repo](https://github.com/pyOpenSci/software-submission) issues where the issue has a label of 6/`pyOS-approved 🚀🚀🚀`.
127+
- Grabs crucial metadata including the reviewers and editors for each.
128+
- Adds people who have participated in peer review who are NOT listed currently in the website `contributors.yml` file
129129

130130
It then collects the
131131
GitHub id and user information for:
132132

133-
- reviewers,
134-
- submitting authors,
135-
- editors and
136-
- maintainers.
133+
- reviewers,
134+
- submitting authors,
135+
- editors and
136+
- maintainers.
137137

138138
Finally, it updates GitHub statistics for
139139
each packages including stars, last commit date and more repo metadata.
@@ -147,8 +147,8 @@ This returns a `packages.pickle` file that will be used in the final script whic
147147
This script is a bridge between `update-contributors` and `update-reviews`. It parses each review in the output
148148
`update-reviews.pickle` file and
149149

150-
1. updates contributor name in the review data (often the github username is there but the first and last name is missing). This allows us to publish the maintainer names (rather than github usernames) [on our website package listing.](https://www.pyopensci.org/python-packages.html#explore-our-accepted-scientific-python-open-source-packages)
151-
2. Updates each review issue contributor's name in the contributor metadata. This allows us to ensure we have updated contributor types, package submission information etc, in the contributor.yml file on our website.
150+
1. updates contributor name in the review data (often the github username is there but the first and last name is missing). This allows us to publish the maintainer names (rather than github usernames) [on our website package listing.](https://www.pyopensci.org/python-packages.html#explore-our-accepted-scientific-python-open-source-packages)
151+
2. Updates each review issue contributor's name in the contributor metadata. This allows us to ensure we have updated contributor types, package submission information etc, in the contributor.yml file on our website.
152152

153153
To run:
154154
`update_reviewers`
@@ -159,8 +159,8 @@ This final script uses the two pickle files
159159
to update information. It then returns
160160
two output files:
161161

162-
1. `_data/contributors.yml`
163-
2. `_data/packages.yml`
162+
1. `_data/contributors.yml`
163+
2. `_data/packages.yml`
164164

165165
Each are stored in the `/_data/file.yml` directory to mimic the directory structure of our website.
166166

@@ -171,8 +171,8 @@ actions located here](https://github.com/pyOpenSci/pyopensci.github.io/tree/main
171171

172172
### Data that these scripts update / maintain
173173

174-
- [website contributors.yml file](https://github.com/pyOpenSci/pyopensci.github.io/blob/main/_data/contributors.yml)
175-
- [website packages.yml file is here](https://github.com/pyOpenSci/pyopensci.github.io/blob/main/_data/packages.yml).
174+
- [website contributors.yml file](https://github.com/pyOpenSci/pyopensci.github.io/blob/main/_data/contributors.yml)
175+
- [website packages.yml file is here](https://github.com/pyOpenSci/pyopensci.github.io/blob/main/_data/packages.yml).
176176

177177
## Rate limiting
178178

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,10 @@
99
**pyosmeta** provides the tools and scripts used to manage [pyOpenSci](https://pyopensci.org)'s contributor and peer
1010
review metadata.
1111
This repo contains a small module and several CLI scripts, including:
12-
- `parse-history`
13-
- `update-contributors`
14-
- `update-reviews`
15-
- `update-review-teams`
12+
- `parse-history`
13+
- `update-contributors`
14+
- `update-reviews`
15+
- `update-review-teams`
1616

1717
*Since pyOpenSci uses this tool for its website, we expect this package to have infrequent releases.*
1818

0 commit comments

Comments
 (0)