Skip to content

Commit a0cfaa8

Browse files
authored
Fix: add partners to contributors (#135)
* Fix: add partners to contributors * Fix: remove print statement from debugging
1 parent 6fbb9cb commit a0cfaa8

File tree

3 files changed

+8
-1
lines changed

3 files changed

+8
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
- Fix: Add tests for all utils functions (@lwasser, #122)
1111
- Fix: Bug where date_accepted is removed (@lwasser, #129)
1212
- Fix: Refactor all GitHub related methods move to gh_client module (@lwasser, #125)
13+
- Add: support for partners and emeritus_editor in contributor model (@lwasser, #133)
1314

1415

1516
## [v0.2.3] - 2024-02-29

src/pyosmeta/cli/update_contributors.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ def main():
3535
"software-peer-review",
3636
"pyopensci.github.io",
3737
"software-review",
38-
"update-web-metadata",
38+
"pyosmeta",
3939
]
4040
json_files = create_paths(repos)
4141

src/pyosmeta/models.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,9 @@ class PersonModel(BaseModel, UrlValidatorMixin):
9696
editorial_board: Optional[bool] = Field(
9797
None, validation_alias=AliasChoices("editorial-board")
9898
)
99+
emeritus_editor: Optional[bool] = Field(
100+
None, validation_alias=AliasChoices("emeritus_editor")
101+
)
99102
advisory: Optional[bool] = False
100103
twitter: Optional[str] = Field(
101104
None, validation_alias=AliasChoices("twitter_username")
@@ -104,6 +107,7 @@ class PersonModel(BaseModel, UrlValidatorMixin):
104107
None, validation_alias=AliasChoices("mastodon_username", "mastodon")
105108
)
106109
orcidid: Optional[str] = None
110+
partners: Optional[list[str]] = None
107111
website: Optional[str] = Field(
108112
None, validation_alias=AliasChoices("blog", "website")
109113
)
@@ -124,6 +128,8 @@ class PersonModel(BaseModel, UrlValidatorMixin):
124128
)
125129
@classmethod
126130
def convert_to_set(cls, value: list[str]):
131+
"""This method converts any list of things ingested into the
132+
model into a set object for cleaner parsing"""
127133
if isinstance(value, list):
128134
if not value:
129135
return set()

0 commit comments

Comments
 (0)