fix: contrib types aligned with repos (#296)

* fix: contrib types aligned with repos

* Fix: uncomment

* fix: tests need updated repo names too

* fix: token in the token var

Author: lwasser

.github/workflows/test-update-contribs.yml

@@ -38,6 +38,9 @@ jobs:
       - name: Create Pull Request
         uses: peter-evans/create-pull-request@271a8d0340265f705b14b6d32b9829c1cb33d45e  # v7.0.8
         with:
+          # Custom token needed to trigger PR checks, as GITHUB_TOKEN won't
+          # https://github.com/peter-evans/create-pull-request/blob/main/docs/concepts-guidelines.md#triggering-further-workflow-runs
+          token: ${{ secrets.PYOS_PR_TOKEN }}
           add-paths: |
             _data/contributors.yml
             _data/packages.yml
@@ -49,7 +52,3 @@ jobs:
           title: Update contributor and review data
           labels: |
             pre-commit.ci autofix
-        env:
-          # Custom token needed to trigger PR checks, as GITHUB_TOKEN won't
-          # https://github.com/peter-evans/create-pull-request/blob/main/docs/concepts-guidelines.md#triggering-further-workflow-runs
-          GITHUB_TOKEN: ${{ secrets.PYOS_PR_TOKEN }}

src/pyosmeta/contributors.py

@@ -83,13 +83,28 @@ def check_contrib_type(self, json_file: str):
             Contribution type.
         """
 
-        if "software-peer-review" in json_file:
+        if any(
+            key in json_file
+            for key in ["software-submission", "software-peer-review"]
+        ):
+            # TODO: change this to programs - peer review
             contrib_type = "peer-review-guide"
-        elif "python-package-guide" in json_file:
+        elif any(
+            key in json_file
+            for key in [
+                "python-package-guide",
+                "pyosPackage",
+                "pyos-package-template",
+            ]
+        ):
+            # TODO consider change this to python-packaging
             contrib_type = "package-guide"
+        # TODO: technically packaging guide is open-education too
+        elif "lessons" in json_file:
+            contrib_type = "open-education"
         elif "pyopensci.github.io" in json_file:
             contrib_type = "web-contrib"
-        elif "update-web-metadata" in json_file:
+        elif "pyosMeta" in json_file or "metrics" in json_file:
             contrib_type = "code-contrib"
         else:
             contrib_type = "community"

tests/unit/test_contributors_module.py

@@ -35,8 +35,7 @@ def test_check_contrib_type(process_contributors):
         == "web-contrib"
     )
     assert (
-        process_contributors.check_contrib_type("update-web-metadata")
-        == "code-contrib"
+        process_contributors.check_contrib_type("pyosMeta") == "code-contrib"
     )
     assert process_contributors.check_contrib_type("other") == "community"