Update contributor and review data #238
Conversation
| location: | ||
| email: | ||
| - name: | ||
| - name: Beryl Kanali |
There was a problem hiding this comment.
@pllim i have a test run that we can use here now !! it captured the changes that you just made to the names!! yay!!
| bio: Software engineer and mathematician | ||
| organization: | ||
| date_added: '2024-03-09' | ||
| date_added: '2024-11-22' |
There was a problem hiding this comment.
This should never be updated as it's the date a contributor was added to this file. This is a bug
There was a problem hiding this comment.
Ooops looks like I added conflicting info back in pyOpenSci/pyopensci.github.io#530 . I didn't realize this file exists in multiple places. Did I change it in the wrong repo?
There was a problem hiding this comment.
@pllim you did everything right. I made a "test" copy of the workflow over here so we can test things every time we make changes to pyosmeta. So please consider this pr a end-to-end test in the pyosmeta not the final website file!!
The goal is to avoid troubleshooting pyosmeta in the website repo and rather to catch things PRIOR to a new release. You corrected things in the right spot!! This date update specifically is i think a bug in our workflow. i don't recall you changing the dates anywhere!!
Does that make sense?
btw - Name was actually in our issue template so i cleaned that up too! i'm finding lots of small bugs thanks to you.
|
i'll rename the pr title end-to-end tests so it's clear that this is a test run, not a real contributor update. |
github-actions
bot
force-pushed
the
contribs
branch
from
14776b6 to
00f346e
Compare
| all_current_maintainers: | ||
| - name: Daniela Huppenkothen | ||
| github_username: dhuppenkothen mgullik jdswinbank matteolucchini1 | ||
| github_username: dhuppenkothen |
There was a problem hiding this comment.
Ok, maintainers are now populating correctly. We just need a small reminder in the issue to add commas for parsing. If this happens again, we can consider adding more logic to the code it will just get complicated, given the many variations that users could provide.
github-actions
bot
force-pushed
the
contribs
branch
from
00f346e to
fdded36
Compare
github-actions
bot
force-pushed
the
contribs
branch
from
fdded36 to
ff6b122
Compare
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #238 +/- ##
=======================================
Coverage 74.06% 74.06%
=======================================
Files 10 10
Lines 671 671
Branches 82 82
=======================================
Hits 497 497
Misses 166 166
Partials 8 8 ☔ View full report in Codecov by Sentry. |
2 participants
Automated changes by create-pull-request GitHub action