fix: publish/release workflow (#73)

Yay!

Author: lwasser

.github/workflows/publish-pypi.yml renamed to .github/workflows/build-publish-pypi.yml

@@ -39,7 +39,7 @@ jobs:
 
       - name: Build package using Hatch
         run: |
-          hatch build
+          hatch run build:check
           echo ""
           echo "Generated files:"
           ls -lh dist/
@@ -49,10 +49,13 @@ jobs:
         with:
           name: python-package-distributions
           path: dist/
+  # The publish step will only run on a release from the pyopensci repository
+  # There are several checks in place including setting up the pypi environment in
+  # GitHub so that only people on your maintainer team can allow the deployment
   publish:
     name: >-
       Publish Python 🐍 distribution 📦 to PyPI
-    if: github.repository_owner == 'pyopensci'
+    if: github.repository_owner == 'pyopensci' && github.event_name == 'release'
     needs:
       - build
     runs-on: ubuntu-latest

.github/workflows/release.yml

@@ -6,6 +6,7 @@
 
 This release fixes many issues with the original template run in "full mode"
 
+* Fix: release.yml broken and combine publish and release builds (@lwasser, #71)
 * Add: fix ci, linting, docs and tests run docs separately (@lwasser)
 * Fix readthedocs build issues fixed by updating .readthedocs.yaml to install docs dependencies and build docs directly & redundant api docs (@lwasser)
 * Add: Move to optional-dependency groups and call those groups in hatch envs (@lwasser)