Add test outlier detection (#298)

* Add test outlier detection

* Update cleansing.py

correcting input_array instead of coords in log message

* Update test_utils_cleansing.py

removed k parameter from cleansing.detect_outliers in test.test_utils_cleansing.test_detect_outlier_input_dims() because not necessary for test and coords is not passed.

Author: chiara-arpae

pysteps/tests/test_utils_cleansing.py

@@ -174,3 +174,9 @@ def test_detect_outlier_multivariate_local():
     V[-1] = (-3, 3)
     outliers = cleansing.detect_outliers(V, 4, coord=X, k=50)
     assert outliers.sum() == 2
+
+def test_detect_outlier_input_dims():
+    V = np.zeros((20, 3, 2))
+    thr_std_devs = 1
+    with pytest.raises(ValueError):
+        cleansing.detect_outliers(V, thr_std_devs)

pysteps/utils/cleansing.py

@@ -172,7 +172,7 @@ def detect_outliers(input_array, thr, coord=None, k=None, verbose=False):
     else:
         raise ValueError(
             f"input_array must have 1 (n) or 2 dimensions (n, m), "
-            f"but it has {coord.ndim}"
+            f"but it has {input_array.ndim}"
         )
 
     if nsamples < 2: