Making ordered set reversible #395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #395 will not alter performanceComparing Summary
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #395 +/- ##
==========================================
- Coverage 99.75% 99.75% -0.01%
==========================================
Files 23 23
Lines 2459 2456 -3
==========================================
- Hits 2453 2450 -3
Misses 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
thanks @yfukai! Nice feature 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered a case in which I would like to get the last element of
Selection. SinceOrderedSetisdict-based, I thought it makes sense to make it reversible so that we can access the last element bynext(reversed(s)).With this motivation, this pull request adds support for reversing iteration in the
EventedOrderedSetandOrderedSetclasses, and introduces new tests to verify this behavior.Enhancements to Ordered Set Containers:
__reversed__method toEventedOrderedSetto support reversed iteration, enabling the use of Python's built-inreversed()function on instances of this class.Testing Improvements:
test_iteratorfunction intests/containers/test_evented_set.pyto validate both forward and reversed iteration forOrderedSetandEventedOrderedSet, ensuring correct order and compatibility with Python's iterator protocol.