Merge pull request #2784 from pybamm-team/issue-2783-benchmarks

fix benchmarks

Author: valentinsulzer

.github/workflows/benchmark_on_push.yml

@@ -38,7 +38,7 @@ jobs:
           HEAD_COMMIT=$(git rev-parse HEAD)
           echo $BASE_COMMIT | tee commits_to_compare.txt
           echo $HEAD_COMMIT | tee -a commits_to_compare.txt
-          asv run HASHFILE:commits_to_compare.txt --m "GitHubRunner" --show-stderr -v
+          asv run HASHFILE:commits_to_compare.txt --m "GitHubRunner" --show-stderr --strict -v
       - name: Compare commits' benchmark results
         run: |
           BASE_COMMIT=$(head -1 commits_to_compare.txt)

asv.conf.json

@@ -24,6 +24,7 @@
   // "install_command": ["in-dir={env_dir} python -mpip install {wheel_file}"],
   // "uninstall_command": ["return-code=any python -mpip uninstall -y {project}"],
   "build_command": [
+    "/bin/rm -rf pybind11",
     "/usr/bin/git clone --depth 1 --branch v2.6.2 https://github.com/pybind/pybind11.git",
     "python setup.py build",
     "PIP_NO_BUILD_ISOLATION=false python -mpip wheel --no-deps --no-index -w {build_cache_dir} {build_dir}"

benchmarks/different_model_options.py

@@ -124,7 +124,7 @@ class TimeSolveLithiumPlating:
 
     def setup(self, model, params, solver_class):
         SolveModel.solve_setup(
-            self, "OKane2020", model, "lithium plating", params, solver_class
+            self, "OKane2022", model, "lithium plating", params, solver_class
         )
 
     def time_solve_model(self, model, params, solver_class):
@@ -139,12 +139,10 @@ class TimeBuildModelSEI:
             "none",
             "constant",
             "reaction limited",
-            "reaction limited (asymmetric)",
             "solvent-diffusion limited",
             "electron-migration limited",
             "interstitial-diffusion limited",
             "ec reaction limited",
-            "ec reaction limited (asymmetric)",
         ],
     )
 
@@ -160,12 +158,10 @@ class TimeSolveSEI:
             "none",
             "constant",
             "reaction limited",
-            "reaction limited (asymmetric)",
             "solvent-diffusion limited",
             "electron-migration limited",
             "interstitial-diffusion limited",
             "ec reaction limited",
-            "ec reaction limited (asymmetric)",
         ],
         [pybamm.CasadiSolver, pybamm.IDAKLUSolver],
     )
@@ -263,6 +259,12 @@ class TimeSolveSurfaceForm:
     )
 
     def setup(self, model, params, solver_class):
+        if (model, params, solver_class) == (
+            pybamm.lithium_ion.SPM,
+            "differential",
+            pybamm.IDAKLUSolver,
+        ):
+            raise NotImplementedError
         SolveModel.solve_setup(
             self, "Marquis2019", model, "surface form", params, solver_class
         )

benchmarks/time_setup_models_and_sims.py

@@ -9,7 +9,7 @@
     "Ramadass2004",
     "Mohtat2020",
     "Chen2020",
-    "Chen2020_plating",
+    "OKane2022",
     "Ecker2015",
 ]
 

benchmarks/time_sims_experiments.py

@@ -21,6 +21,13 @@ class TimeSimulation:
     }
 
     def setup(self, experiment, parameters, model_class, solver_class):
+        if (experiment, parameters, model_class, solver_class) == (
+            "GITT",
+            "Marquis2019",
+            pybamm.lithium_ion.DFN,
+            pybamm.CasadiSolver,
+        ):
+            raise NotImplementedError
         self.param = pybamm.ParameterValues(parameters)
         self.model = model_class()
         self.solver = solver_class()

benchmarks/time_solve_models.py

@@ -145,6 +145,12 @@ class TimeSolveDFN:
     )
 
     def setup(self, solve_first, parameters, solver_class):
+        if (solve_first, parameters, solver_class) == (
+            True,
+            "ORegan2022",
+            pybamm.CasadiSolver,
+        ):
+            raise NotImplementedError
         self.solver = solver_class()
         self.model = pybamm.lithium_ion.DFN()
         c_rate = 1

pybamm/input/parameters/lithium_ion/Marquis2019.py

@@ -380,6 +380,7 @@ def get_parameter_values():
         "Inner SEI reaction proportion": 0.5,
         "Inner SEI partial molar volume [m3.mol-1]": 9.585e-05,
         "Outer SEI partial molar volume [m3.mol-1]": 9.585e-05,
+        "SEI growth transfer coefficient": 0.5,
         "SEI reaction exchange current density [A.m-2]": 1.5e-07,
         "SEI resistivity [Ohm.m]": 200000.0,
         "Outer SEI solvent diffusivity [m2.s-1]": 2.5000000000000002e-22,