Skip to content

Commit 2f7965f

Browse files
committed
do not review this commit
1 parent 566e3d0 commit 2f7965f

File tree

2 files changed

+2
-12
lines changed

2 files changed

+2
-12
lines changed

pybamm/models/full_battery_models/lithium_ion/electrode_soh.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -598,7 +598,7 @@ def theoretical_energy_integral(parameter_values, n_i, n_f, p_i, p_f, points=100
598598

599599

600600
def calculate_theoretical_energy(
601-
parameter_values, initial_soc=1.0, final_soc=0.0, points=100, initial_stoichs=None
601+
parameter_values, initial_soc=1.0, final_soc=0.0, points=100
602602
):
603603
"""
604604
Calculate maximum energy possible from a cell given OCV, initial soc, and final soc
@@ -611,7 +611,7 @@ def calculate_theoretical_energy(
611611
initial_soc : float
612612
The soc at begining of discharge, default 1.0
613613
final_soc : float
614-
The soc at end of discharge, default 1.0
614+
The soc at end of discharge, default 0.0
615615
points : int
616616
The number of points at which to calculate voltage.
617617

pybamm/solvers/solution.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -880,14 +880,4 @@ def _get_cycle_summary_variables(cycle_solution, esoh_solver):
880880
for var in esoh_sol.all_models[0].variables:
881881
cycle_summary_variables[var] = esoh_sol[var].data[0]
882882

883-
# Calculate theoretical energy
884-
n_f = cycle_summary_variables["x_0"]
885-
p_f = cycle_summary_variables["y_0"]
886-
n_i = n_f + cycle_summary_variables["x_100 - x_0"]
887-
p_i = p_f - cycle_summary_variables["y_0 - y_100"]
888-
energy = pybamm.lithium_ion.electrode_soh.theoretical_energy_integral(
889-
esoh_solver.parameter_values, n_i, n_f, p_i, p_f
890-
)
891-
cycle_summary_variables["Maximum theoretical energy [W.h]"] = energy
892-
893883
return cycle_summary_variables

0 commit comments

Comments
 (0)