Merge branch 'develop' into i2643-banded

Author: valentinsulzer

.all-contributorsrc

@@ -550,7 +550,18 @@
       "avatar_url": "https://avatars.githubusercontent.com/u/112731474?v=4",
       "profile": "https://github.com/iatzak",
       "contributions": [
-        "doc"
+        "doc",
+        "bug",
+        "code"
+      ]
+    },
+    {
+      "login": "ayeankit",
+      "name": "Ankit Kumar",
+      "avatar_url": "https://avatars.githubusercontent.com/u/72691866?v=4",
+      "profile": "https://github.com/ayeankit",
+      "contributions": [
+        "code"
       ]
     }
   ],

.github/workflows/url_checker.yml

@@ -13,7 +13,7 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v3
       - name: URLs-checker
-        uses: urlstechie/urlchecker-action@0.0.31
+        uses: urlstechie/urlchecker-action@master
         with:
           # A comma-separated list of file types to cover in the URL checks
           file_types: .rst,.md,.py,.ipynb

.gitignore

@@ -6,6 +6,7 @@
 *.DS_Store
 *.mat
 *.csv
+*.hidden
 
 # don't ignore important .txt and .csv files
 !requirements*

.pre-commit-config.yaml

@@ -10,12 +10,12 @@ repos:
         exclude: assets/js/webapp\.js
 
   - repo: https://github.com/psf/black
-    rev: 22.12.0
+    rev: 23.1.0
     hooks:
       - id: black
 
   - repo: https://github.com/charliermarsh/ruff-pre-commit
-    rev: "v0.0.237"
+    rev: "v0.0.246"
     hooks:
       - id: ruff
         args: [--ignore=E741, --exclude=__init__.py]

CHANGELOG.md

@@ -1,5 +1,14 @@
 # [Unreleased](https://github.com/pybamm-team/PyBaMM/)
 
+## Features
+
+- Added temperature control to experiment class. ([#2518])(https://github.com/pybamm-team/PyBaMM/pull/2518)
+- The "particle size" option can now be a tuple to allow different behaviour in each electrode([#2672](https://github.com/pybamm-team/PyBaMM/pull/2672)).
+
+## Bug fixes
+
+- Fixed the length scaling for the first dimension of r-R plots ([#2663](https://github.com/pybamm-team/PyBaMM/pull/2663)).
+
 # [v23.1](https://github.com/pybamm-team/PyBaMM/tree/v23.1) - 2023-01-31
 
 ## Features

README.md

@@ -83,7 +83,6 @@ class TimeBuildModelLossActiveMaterial:
     )
 
     def time_setup_model(self, model, params):
-
         build_model("Ai2020", model, "loss of active material", params)
 
 

benchmarks/different_model_options.py

@@ -35,9 +35,7 @@
     itertools.product(solvers.values(), models.values()),
     itertools.product(solvers, models),
 ):
-
     for params in parameters:
-
         time_points = []
         solver = i[0]
 
@@ -70,13 +68,11 @@
         disc.process_model(model)
 
         for tol in abstols:
-
             solver.atol = tol
             solver.solve(model, t_eval=t_eval)
             time = 0
             runs = 20
             for k in range(0, runs):
-
                 solution = solver.solve(model, t_eval=t_eval)
                 time += solution.solve_time.value
             time = time / runs

benchmarks/work_precision_sets/time_vs_abstols.py

@@ -39,9 +39,7 @@
     models.values(),
     models,
 ):
-
     for params in parameters:
-
         time_points = []
         # solver = pybamm.CasadiSolver()
 
@@ -74,14 +72,12 @@
         disc.process_model(model)
 
         for t in dt_max:
-
             solver = pybamm.CasadiSolver(dt_max=t)
 
             solver.solve(model, t_eval=t_eval)
             time = 0
             runs = 20
             for k in range(0, runs):
-
                 solution = solver.solve(model, t_eval=t_eval)
                 time += solution.solve_time.value
             time = time / runs

benchmarks/work_precision_sets/time_vs_dt_max.py

@@ -29,7 +29,6 @@
     itertools.product(solvers.values(), models.values()),
     itertools.product(solvers, models),
 ):
-
     for params in parameters:
         time_points = []
         solver = i[0]
@@ -42,7 +41,6 @@
         i = list(i)
 
         for N in npts:
-
             var_pts = {
                 "x_n": N,  # negative electrode
                 "x_s": N,  # separator
@@ -57,7 +55,6 @@
             time = 0
             runs = 20
             for k in range(0, runs):
-
                 solution = sim.solve([0, 3500])
                 time += solution.solve_time.value
             time = time / runs