Skip to content

Commit 7855a1f

Browse files
Merge pull request #2542 from agriyakhetarpal/2347-remove-tutorials
Remove tutorials from readthedocs
2 parents bf76f86 + 15241d7 commit 7855a1f

31 files changed

+71
-458
lines changed

CONTRIBUTING.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ We use [black](https://black.readthedocs.io/en/stable/) to automatically configu
8585
black {source_file_or_directory}
8686
```
8787

88-
2. Editor: black can be [configured](https://test-black.readthedocs.io/en/latest/editor_integration.html) to automatically reformat a python script each time the script is saved in an editor.
88+
2. Editor: black can be [configured](https://test-black.readthedocs.io/en/latest/editor_integration.html) to automatically reformat a Python script each time the script is saved in an editor.
8989

9090
If you want to use black in your editor, you may need to change the max line length in your editor settings.
9191

@@ -214,7 +214,7 @@ This also means that, if you can't fix the bug yourself, it will be much easier
214214

215215
or by just commenting out all the tests you don't want to run.
216216

217-
2. Set break points, either in your IDE or using the python debugging module. To use the latter, add the following line where you want to set the break point
217+
2. Set break points, either in your IDE or using the Python debugging module. To use the latter, add the following line where you want to set the break point
218218

219219
```python
220220
import ipdb; ipdb.set_trace()
@@ -257,7 +257,7 @@ This also means that, if you can't fix the bug yourself, it will be much easier
257257

258258
You can then step through the expression tree, using the `children` attribute, to pinpoint exactly where a bug is coming from. For example, if `expression_tree.jac(y)` is failing, you can check `expression_tree.children[0].jac(y)`, then `expression_tree.children[0].children[0].jac(y)`, etc.
259259

260-
3. To isolate whether a bug is in a model, its jacobian or its simplified version, you can set the `use_jacobian` and/or `use_simplify` attributes of the model to `False` (they are both `True` by default for most models).
260+
3. To isolate whether a bug is in a model, its Jacobian or its simplified version, you can set the `use_jacobian` and/or `use_simplify` attributes of the model to `False` (they are both `True` by default for most models).
261261
4. If a model isn't giving the answer you expect, you can try comparing it to other models. For example, you can investigate parameter limits in which two models should give the same answer by setting some parameters to be small or zero. The `StandardOutputComparison` class can be used to compare some standard outputs from battery models.
262262
5. To get more information about what is going on under the hood, and hence understand what is causing the bug, you can set the [logging](https://realpython.com/python-logging/) level to `DEBUG` by adding the following line to your test or script:
263263

@@ -340,9 +340,9 @@ Adding the command
340340
pybamm.print_citations()
341341
```
342342

343-
to the end of a script will print all citations that were used by that script. This will print bibtex information to the terminal; passing a filename to `print_citations` will print the bibtex information to the specified file instead.
343+
to the end of a script will print all citations that were used by that script. This will print BibTeX information to the terminal; passing a filename to `print_citations` will print the BibTeX information to the specified file instead.
344344

345-
When you contribute code to PyBaMM, you can add your own papers that you would like to be cited if that code is used. First, add the bibtex for your paper to [CITATIONS.txt](pybamm/CITATIONS.txt). Then, add the line
345+
When you contribute code to PyBaMM, you can add your own papers that you would like to be cited if that code is used. First, add the BibTeX for your paper to [CITATIONS.txt](pybamm/CITATIONS.txt). Then, add the line
346346

347347
```python3
348348
pybamm.citations.register("your_paper_bibtex_identifier")
@@ -368,7 +368,7 @@ Note that this file must be kept in sync with the version number in [pybamm/**in
368368

369369
Each change pushed to the PyBaMM GitHub repository will trigger the test and benchmark suites to be run, using [GitHub actions](https://github.com/features/actions).
370370

371-
Tests are run for different operating systems, and for all python versions officially supported by PyBaMM. If you opened a Pull Request, feedback is directly available on the corresponding page. If all tests pass, a green tick will be displayed next to the corresponding test run. If one or more test(s) fail, a red cross will be displayed instead.
371+
Tests are run for different operating systems, and for all Python versions officially supported by PyBaMM. If you opened a Pull Request, feedback is directly available on the corresponding page. If all tests pass, a green tick will be displayed next to the corresponding test run. If one or more test(s) fail, a red cross will be displayed instead.
372372

373373
Similarly, the benchmark suite is automatically run for the most recently pushed commit. Benchmark results are compared to the results available for the latest commit on the `develop` branch. Should any significant performance regression be found, a red cross will be displayed next to the benchmark run.
374374

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ If you use PyBaMM in your work, please cite our paper
111111

112112
> Sulzer, V., Marquis, S. G., Timms, R., Robinson, M., & Chapman, S. J. (2021). Python Battery Mathematical Modelling (PyBaMM). _Journal of Open Research Software, 9(1)_.
113113
114-
You can use the bibtex
114+
You can use the BibTeX
115115

116116
```
117117
@article{Sulzer2021,
@@ -133,7 +133,7 @@ We would be grateful if you could also cite the relevant papers. These will chan
133133
pybamm.print_citations()
134134
```
135135

136-
to the end of your script. This will print bibtex information to the terminal; passing a filename to `print_citations` will print the bibtex information to the specified file instead. A list of all citations can also be found in the [citations file](https://github.com/pybamm-team/PyBaMM/blob/develop/pybamm/CITATIONS.txt). In particular, PyBaMM relies heavily on [CasADi](https://web.casadi.org/publications/).
136+
to the end of your script. This will print BibTeX information to the terminal; passing a filename to `print_citations` will print the BibTeX information to the specified file instead. A list of all citations can also be found in the [citations file](https://github.com/pybamm-team/PyBaMM/blob/develop/pybamm/CITATIONS.txt). In particular, PyBaMM relies heavily on [CasADi](https://web.casadi.org/publications/).
137137
See [CONTRIBUTING.md](https://github.com/pybamm-team/PyBaMM/blob/develop/CONTRIBUTING.md#citations) for information on how to add your own citations when you contribute.
138138

139139
## 🛠️ Contributing to PyBaMM

docs/index.rst

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -96,13 +96,6 @@ and run locally using ``jupyter notebook``, or online through
9696
Contributing
9797
============
9898

99-
There are many ways to contribute to PyBaMM:
100-
101-
.. toctree::
102-
:maxdepth: 1
103-
104-
tutorials/add-model
105-
tutorials/add-spatial-method
106-
tutorials/add-solver
99+
Contributions to PyBaMM and its development are welcome! If you have ideas for features, bug fixes, models, spatial methods, or solvers, we would love to hear from you.
107100

108101
Before contributing, please read the `Contribution Guidelines <https://github.com/pybamm-team/PyBaMM/blob/develop/CONTRIBUTING.md>`_.

docs/install/GNU-linux.rst

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ brew <https://docs.python-guide.org/starting/install3/osx/>`__:
2828

2929
.. code:: bash
3030
31-
ruby -e "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install)"
31+
ruby -e "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/HEAD/install.sh)"
3232
3333
then follow instructions in link on adding brew to path, and run
3434

@@ -45,8 +45,8 @@ User install
4545
------------
4646

4747
We recommend to install PyBaMM within a virtual environment, in order
48-
not to alter any distribution python files.
49-
First, make sure you are using python 3.8 or 3.9.
48+
not to alter any distribution Python files.
49+
First, make sure you are using Python 3.8 or 3.9.
5050
To create a virtual environment ``env`` within your current directory type:
5151

5252
.. code:: bash
@@ -161,7 +161,7 @@ repository
161161
git clone https://github.com/pybamm-team/PyBaMM.git
162162
cd PyBaMM
163163
164-
Then, to install PyBaMM as a `developer <CONTRIBUTING.md>`__, type
164+
Then, to install PyBaMM as a `developer <https://github.com/pybamm-team/PyBaMM/blob/develop/CONTRIBUTING.md>`__, type
165165

166166
.. code:: bash
167167
@@ -174,7 +174,7 @@ To check whether PyBaMM has installed properly, you can run the tests:
174174
python3 run-tests.py --unit
175175
176176
Before you start contributing to PyBaMM, please read the `contributing
177-
guidelines <CONTRIBUTING.md>`__.
177+
guidelines <https://github.com/pybamm-team/PyBaMM/blob/develop/CONTRIBUTING.md>`__.
178178

179179
Uninstall PyBaMM
180180
================

docs/install/install-from-source.rst

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ Install from source (developer install)
55

66
This page describes the build and installation of PyBaMM from the source code, available on GitHub. Note that this is **not the recommended approach for most users** and should be reserved to people wanting to participate in the development of PyBaMM, or people who really need to use bleeding-edge feature(s) not yet available in the latest released version. If you do not fall in the two previous categories, you would be better off installing PyBaMM using pip or conda.
77

8-
Lastly, familiarity with the python ecosystem is recommended (pip, virtualenvs).
8+
Lastly, familiarity with the Python ecosystem is recommended (pip, virtualenvs).
99
Here is a gentle introduction/refresher: `Python Virtual Environments: A Primer <https://realpython.com/python-virtual-environments-a-primer/>`_.
1010

1111

@@ -26,7 +26,7 @@ or download the source archive on the repository's homepage.
2626
To install PyBaMM, you will need:
2727

2828
- Python 3 (PyBaMM supports versions 3.8 and 3.9)
29-
- The python headers file for your current python version.
29+
- The Python headers file for your current Python version.
3030
- A BLAS library (for instance `openblas <https://www.openblas.net/>`_).
3131
- A C compiler (ex: ``gcc``).
3232
- A Fortran compiler (ex: ``gfortran``).
@@ -52,7 +52,7 @@ You can install it with
5252
5353
python3.X -m pip install --user "tox<4"
5454
55-
Depending on your operating system, you may or may not have ``pip`` installed along python.
55+
Depending on your operating system, you may or may not have ``pip`` installed along Python.
5656
If ``pip`` is not found, you probably want to install the ``python3-pip`` package.
5757

5858
Installing the build-time requirements
@@ -105,7 +105,7 @@ If you'd rather do things yourself,
105105
4. Clone the pybind11 repository in the ``PyBaMM/`` directory (make sure the directory is named ``pybind11``).
106106

107107

108-
PyBaMM ships with a python script that automates points 2. and 3. You can run it with
108+
PyBaMM ships with a Python script that automates points 2. and 3. You can run it with
109109

110110
.. code:: bash
111111
@@ -198,7 +198,7 @@ You can run unit tests for PyBaMM using
198198
199199
200200
The above starts a sub-process using the current python interpreter (i.e. using your current
201-
python environment) and run the unit tests. This can take a few minutes.
201+
Python environment) and run the unit tests. This can take a few minutes.
202202

203203
You can also use the test runner to run the doctests:
204204

docs/install/windows-wsl.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ Use Visual Studio Code to run PyBaMM
6464

6565
You will probably want to use a native Windows IDE such as Visual Studio
6666
Code or the full Microsoft Visual Studio IDE. Both of these packages can
67-
connect to WSL so that you can write python code in a native windows
67+
connect to WSL so that you can write Python code in a native windows
6868
environment, while at the same time using WSL to run the code using your
6969
installed Ubuntu distribution. The following instructions assume that
7070
you are using Visual Studio Code.

0 commit comments

Comments
 (0)