Skip to content

Commit 9a479cf

Browse files
authored
Make ParameterValues.pop return a value (#4571)
* Fix pop * Remove some text
1 parent 4a50562 commit 9a479cf

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

src/pybamm/parameters/parameter_values.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
1-
#
2-
# Parameter values for a simulation
3-
#
41
import numpy as np
52
import pybamm
63
import numbers
@@ -184,7 +181,7 @@ def items(self):
184181
return self._dict_items.items()
185182

186183
def pop(self, *args, **kwargs):
187-
self._dict_items.pop(*args, **kwargs)
184+
return self._dict_items.pop(*args, **kwargs)
188185

189186
def copy(self):
190187
"""Returns a copy of the parameter values. Makes sure to copy the internal

0 commit comments

Comments
 (0)