Skip to content

Commit bebe08e

Browse files
committed
NotImplementedError for more benchmarks
1 parent e8a9c64 commit bebe08e

File tree

3 files changed

+17
-4
lines changed

3 files changed

+17
-4
lines changed

benchmarks/different_model_options.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -263,10 +263,10 @@ class TimeSolveSurfaceForm:
263263
)
264264

265265
def setup(self, model, params, solver_class):
266-
if (
267-
model == pybamm.lithium_ion.SPM
268-
and params == "differential"
269-
and solver_class == pybamm.IDAKLUSolver
266+
if (model, params, solver_class) == (
267+
pybamm.lithium_ion.SPM,
268+
"differential",
269+
pybamm.IDAKLUSolver,
270270
):
271271
raise NotImplementedError
272272
SolveModel.solve_setup(

benchmarks/time_sims_experiments.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,13 @@ class TimeSimulation:
2121
}
2222

2323
def setup(self, experiment, parameters, model_class, solver_class):
24+
if (experiment, parameters, model_class, solver_class) == (
25+
"GITT",
26+
"Marquis2019",
27+
pybamm.lithium_ion.DFN,
28+
pybamm.CasadiSolver,
29+
):
30+
raise NotImplementedError
2431
self.param = pybamm.ParameterValues(parameters)
2532
self.model = model_class()
2633
self.solver = solver_class()

benchmarks/time_solve_models.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,12 @@ class TimeSolveDFN:
145145
)
146146

147147
def setup(self, solve_first, parameters, solver_class):
148+
if (solve_first, parameters, solver_class) == (
149+
True,
150+
"ORegan2022",
151+
pybamm.CasadiSolver,
152+
):
153+
raise NotImplementedError
148154
self.solver = solver_class()
149155
self.model = pybamm.lithium_ion.DFN()
150156
c_rate = 1

0 commit comments

Comments
 (0)