coverage

Author: valentinsulzer

pybamm/expression_tree/concatenations.py

@@ -380,16 +380,12 @@ def __init__(self, *children):
                 raise ValueError("Cannot concatenate symbols with different bounds")
         super().__init__(*children, name=name)
 
-        if not any(c._raw_print_name is None for c in children):
-            print_name = intersect(
-                children[0]._raw_print_name, children[1]._raw_print_name
-            )
-            for child in children[2:]:
-                print_name = intersect(print_name, child._raw_print_name)
-            if print_name.endswith("_"):
-                print_name = print_name[:-1]
-        else:
-            print_name = None
+        print_name = intersect(children[0]._raw_print_name, children[1]._raw_print_name)
+        for child in children[2:]:
+            print_name = intersect(print_name, child._raw_print_name)
+        if print_name.endswith("_"):
+            print_name = print_name[:-1]
+
         self.print_name = print_name
 
 

pybamm/simulation.py

@@ -392,14 +392,10 @@ def set_parameters(self):
         if self.model_with_set_params:
             return
 
-        if self._parameter_values._dict_items == {}:
-            # Don't process if parameter values is empty
-            self._model_with_set_params = self._unprocessed_model
-        else:
-            self._model_with_set_params = self._parameter_values.process_model(
-                self._unprocessed_model, inplace=False
-            )
-            self._parameter_values.process_geometry(self.geometry)
+        self._model_with_set_params = self._parameter_values.process_model(
+            self._unprocessed_model, inplace=False
+        )
+        self._parameter_values.process_geometry(self.geometry)
         self.model = self._model_with_set_params
 
     def set_initial_soc(self, initial_soc):

tests/unit/test_simulation.py

@@ -11,11 +11,9 @@ class TestSimulation(unittest.TestCase):
     def test_simple_model(self):
         model = pybamm.BaseModel()
         v = pybamm.Variable("v")
-        a = pybamm.Parameter("a")
-        model.rhs = {v: -a * v}
+        model.rhs = {v: -v}
         model.initial_conditions = {v: 1}
-        param = pybamm.ParameterValues({"a": 1})
-        sim = pybamm.Simulation(model, parameter_values=param)
+        sim = pybamm.Simulation(model)
         sol = sim.solve([0, 1])
         np.testing.assert_array_almost_equal(sol.y.full()[0], np.exp(-sol.t), decimal=5)