Merge branch 'develop' of https://github.com/pybamm-team/PyBaMM into v24.5

Author: Saransh-cpp

.all-contributorsrc

@@ -1,13 +1,14 @@
 {
   "files": [
-    "all_contributors.md"
+    "all_contributors.md",
+    "README.md"
   ],
   "imageSize": 100,
   "commit": false,
   "badgeTemplate": "[![All Contributors](https://img.shields.io/badge/all_contributors-<%= contributors.length %>-orange.svg)](#-contributors)",
   "contributors": [
     {
-      "login": "tinosulzer",
+      "login": "valentinsulzer",
       "name": "Valentin Sulzer",
       "avatar_url": "https://avatars3.githubusercontent.com/u/20817509?v=4",
       "profile": "https://sites.google.com/view/valentinsulzer",
@@ -856,6 +857,89 @@
       "contributions": [
         "doc"
       ]
+    },
+    {
+      "login": "Hongmeiqi",
+      "name": "Hongmeiqi",
+      "avatar_url": "https://avatars.githubusercontent.com/u/143798726?v=4",
+      "profile": "https://github.com/Hongmeiqi",
+      "contributions": [
+        "doc"
+      ]
+    },
+    {
+      "login": "mleot",
+      "name": "mleot",
+      "avatar_url": "https://avatars.githubusercontent.com/u/140573653?v=4",
+      "profile": "https://github.com/mleot",
+      "contributions": [
+        "code",
+        "test"
+      ]
+    },
+    {
+      "login": "abhicodes369",
+      "name": "Abhi ram",
+      "avatar_url": "https://avatars.githubusercontent.com/u/119055274?v=4",
+      "profile": "https://github.com/abhicodes369",
+      "contributions": [
+        "test"
+      ]
+    },
+    {
+      "login": "parkec3",
+      "name": "Caitlin D. Parke",
+      "avatar_url": "https://avatars.githubusercontent.com/u/26883801?v=4",
+      "profile": "https://github.com/parkec3",
+      "contributions": [
+        "code"
+      ]
+    },
+    {
+      "login": "Afgr1087",
+      "name": "Andres Felipe Galvis Rodriguez",
+      "avatar_url": "https://avatars.githubusercontent.com/u/56610829?v=4",
+      "profile": "https://github.com/Afgr1087",
+      "contributions": [
+        "code"
+      ]
+    },
+    {
+      "login": "ikorotkin",
+      "name": "Ivan Korotkin",
+      "avatar_url": "https://avatars.githubusercontent.com/u/29599800?v=4",
+      "profile": "https://github.com/ikorotkin",
+      "contributions": [
+        "code"
+      ]
+    },
+    {
+      "login": "santacodes",
+      "name": "Santhosh",
+      "avatar_url": "https://avatars.githubusercontent.com/u/52504160?v=4",
+      "profile": "https://github.com/santacodes",
+      "contributions": [
+        "code",
+        "infra"
+      ]
+    },
+    {
+      "login": "smitasahu2",
+      "name": "Smita Sahu",
+      "avatar_url": "https://avatars.githubusercontent.com/u/57876346?v=4",
+      "profile": "https://github.com/smitasahu2",
+      "contributions": [
+        "code"
+      ]
+    },
+    {
+      "login": "Ubham16",
+      "name": "Ubham16",
+      "avatar_url": "https://avatars.githubusercontent.com/u/173074476?v=4",
+      "profile": "https://github.com/Ubham16",
+      "contributions": [
+        "code"
+      ]
     }
   ],
   "contributorsPerLine": 7,

.github/CODEOWNERS

@@ -1,17 +1,17 @@
 # Automatically request reviews from maintainers
 
 # Package
-/pybamm/discretisations/ @martinjrobins @rtimms @tinosulzer
-/pybamm/experiment/ @brosaplanella @martinjrobins @rtimms @tinosulzer @TomTranter
-/pybamm/expression_tree/ @martinjrobins @rtimms @tinosulzer
-/pybamm/geometry/ @martinjrobins @rtimms @tinosulzer
-/pybamm/input/ @brosaplanella @DrSOKane @rtimms @tinosulzer @TomTranter @kratman
-/pybamm/meshes/ @martinjrobins @rtimms @tinosulzer @rtimms
-/pybamm/models/ @brosaplanella @DrSOKane @rtimms @tinosulzer @TomTranter @rtimms
-/pybamm/parameters/ @brosaplanella @DrSOKane @rtimms @tinosulzer @TomTranter @rtimms  @kratman
-/pybamm/plotting/ @martinjrobins @rtimms @Saransh-cpp @tinosulzer @rtimms  @kratman @agriyakhetarpal
-/pybamm/solvers/ @martinjrobins @rtimms @tinosulzer @TomTranter @rtimms
-/pybamm/spatial_methods/ @martinjrobins @rtimms @tinosulzer @rtimms
+/pybamm/discretisations/ @martinjrobins @rtimms @valentinsulzer
+/pybamm/experiment/ @brosaplanella @martinjrobins @rtimms @valentinsulzer @TomTranter
+/pybamm/expression_tree/ @martinjrobins @rtimms @valentinsulzer
+/pybamm/geometry/ @martinjrobins @rtimms @valentinsulzer
+/pybamm/input/ @brosaplanella @DrSOKane @rtimms @valentinsulzer @TomTranter @kratman
+/pybamm/meshes/ @martinjrobins @rtimms @valentinsulzer @rtimms
+/pybamm/models/ @brosaplanella @DrSOKane @rtimms @valentinsulzer @TomTranter @rtimms
+/pybamm/parameters/ @brosaplanella @DrSOKane @rtimms @valentinsulzer @TomTranter @rtimms  @kratman
+/pybamm/plotting/ @martinjrobins @rtimms @Saransh-cpp @valentinsulzer @rtimms  @kratman @agriyakhetarpal
+/pybamm/solvers/ @martinjrobins @rtimms @valentinsulzer @TomTranter @rtimms
+/pybamm/spatial_methods/ @martinjrobins @rtimms @valentinsulzer @rtimms
 /pybamm/* @pybamm-team/maintainers # the files directly under /pybamm/, will not recurse
 
 # CI/CD workflows

.github/ISSUE_TEMPLATE/bug_report.yml

@@ -34,7 +34,7 @@ body:
     id: reproduce
     attributes:
       label: Steps to Reproduce
-      description: Tell us how to reproduce this behaviour. Ideally, this should take the form of a [Minimum Workable Example](https://stackoverflow.com/help/minimal-reproducible-example)
+      description: Tell us how to reproduce this behaviour. Ideally, this should include a code block which produces the error. Strive to make this example as small and simple as possible. It should contain the code required to reproduce the error, and no additional code. For example, if your code includes lines to run a simulation, then lines to plot the results, and the lines to run the simulation fail, only include those lines (and not the plotting lines, which are irrelevant). Often, the act of simplifying code to pinpoint errors can help you find bugs in your own code. For more information, see [these references](https://en.wikipedia.org/wiki/Minimal_reproducible_example#External_links)
     validations:
       required: true
   - type: textarea

.github/ISSUE_TEMPLATE/config.yml

@@ -1,5 +1,5 @@
 blank_issues_enabled: true
 contact_links:
   - name: I'm unsure where to go
-    url: https://www.pybamm.org/contact
+    url: https://www.pybamm.org/community
     about: If you are unsure where to go, then joining our chat is recommended; Just ask!

.github/workflows/docker.yml

@@ -30,7 +30,7 @@ jobs:
             password: ${{ secrets.DOCKERHUB_TOKEN }}
 
       - name: Build and push Docker image to Docker Hub
-        uses: docker/build-push-action@v5
+        uses: docker/build-push-action@v6
         with:
           context: .
           file: scripts/Dockerfile