Skip to content

Commit dcc1f6c

Browse files
aabillsrtimms
andauthored
Hysteresis ESOH (#5163)
* hyst * more progress * asdf * passing tests * test * wrap main * working but not numerically * fix * wrap * fix error? * fix direction issue * add direction to mohtat test * fix notebook * add initial state setting * fix hysteresis * reduce calls to _get_lithiation_delithiation * update docs --------- Co-authored-by: Robert Timms <[email protected]> Co-authored-by: rtimms <[email protected]>
1 parent bb4b654 commit dcc1f6c

File tree

15 files changed

+676
-197
lines changed

15 files changed

+676
-197
lines changed

src/pybamm/input/parameters/lithium_ion/Chen2020_composite.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ def silicon_ocp_lithiation_Mark2016(sto):
8282
+ p6 * sto**2
8383
+ p7 * sto
8484
+ p8
85-
)
85+
) + 1e-4 * (1 / sto + 1 / (sto - 1))
8686
return U_lithiation
8787

8888

@@ -205,7 +205,7 @@ def nmc_LGM50_ocp_Chen2020(sto):
205205
- 0.0428 * np.tanh(18.5138 * (sto - 0.5542))
206206
- 17.7326 * np.tanh(15.7890 * (sto - 0.3117))
207207
+ 17.5842 * np.tanh(15.9308 * (sto - 0.3120))
208-
)
208+
) + 1e-4 * (1 / sto + 1 / (sto - 1))
209209

210210
return u_eq
211211

src/pybamm/models/full_battery_models/equivalent_circuit/initial_state.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
def set_initial_state(
77
initial_value,
88
parameter_values,
9+
direction=None,
910
param=None,
1011
inplace=True,
1112
options=None,

0 commit comments

Comments
 (0)