Merge pull request #2663 from iatzak/r-R-scaling

Remove conditional for scaling of r-R plots

Author: valentinsulzer

CHANGELOG.md

@@ -13,6 +13,7 @@
 
 - Fixed a bug where the solid phase conductivity was double-corrected for tortuosity when loading parameters from a BPX file ([#2638](https://github.com/pybamm-team/PyBaMM/pull/2638)).
 - Changed termination from "success" to "final time" for algebraic solvers to match ODE/DAE solvers ([#2613](https://github.com/pybamm-team/PyBaMM/pull/2613)).
+- Fixed the length scaling for the first dimension of r-R plots ([#2663](https://github.com/pybamm-team/PyBaMM/pull/2663)).
 
 # [v22.12](https://github.com/pybamm-team/PyBaMM/tree/v22.12) - 2022-12-31
 

pybamm/solvers/processed_variable.py

@@ -362,14 +362,9 @@ def initialise_2D(self):
         # assign attributes for reference
         self.entries = entries
         self.dimensions = 2
-        if self.first_dimension == "r" and self.second_dimension == "R":
-            # for an r-R variable, must leave r nondimensional as it was scaled using
-            # R
-            first_length_scale = 1
-        else:
-            first_length_scale = self.get_spatial_scale(
-                self.first_dimension, self.domain[0]
-            )
+        first_length_scale = self.get_spatial_scale(
+            self.first_dimension, self.domain[0]
+        )
         first_dim_pts_for_interp = first_dim_pts * first_length_scale
 
         second_length_scale = self.get_spatial_scale(