Skip to content

Commit e43b7b0

Browse files
committed
#2669 integration tests
1 parent 352ac51 commit e43b7b0

File tree

2 files changed

+13
-5
lines changed

2 files changed

+13
-5
lines changed

pybamm/models/full_battery_models/base_battery_model.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -952,7 +952,6 @@ def build_model_equations(self):
952952
self.check_no_repeated_keys()
953953

954954
def build_model(self):
955-
956955
# Build model variables and equations
957956
self._build_model()
958957

@@ -1075,7 +1074,6 @@ def set_transport_efficiency_submodels(self):
10751074
] = pybamm.transport_efficiency.Bruggeman(self.param, "Electrode", self.options)
10761075

10771076
def set_thermal_submodel(self):
1078-
10791077
if self.options["thermal"] == "isothermal":
10801078
thermal_submodel = pybamm.thermal.isothermal.Isothermal
10811079
elif self.options["thermal"] == "lumped":
@@ -1094,7 +1092,6 @@ def set_thermal_submodel(self):
10941092
self.submodels["thermal"] = thermal_submodel(self.param, self.options)
10951093

10961094
def set_current_collector_submodel(self):
1097-
10981095
if self.options["current collector"] in ["uniform"]:
10991096
submodel = pybamm.current_collector.Uniform(self.param)
11001097
elif self.options["current collector"] == "potential pair":

tests/integration/test_models/test_full_battery_models/test_lithium_ion/test_mpm.py

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,19 @@ def test_differential_surface_form(self):
5151
def test_current_sigmoid_ocp(self):
5252
options = {"open circuit potential": ("current sigmoid", "single")}
5353
model = pybamm.lithium_ion.MPM(options)
54-
modeltest = tests.StandardModelTest(model)
55-
modeltest.test_all()
54+
parameter_values = pybamm.ParameterValues("Chen2020")
55+
parameter_values = pybamm.get_size_distribution_parameters(parameter_values)
56+
parameter_values.update(
57+
{
58+
"Negative electrode lithiation OCP [V]"
59+
"": parameter_values["Negative electrode OCP [V]"],
60+
"Negative electrode delithiation OCP [V]"
61+
"": parameter_values["Negative electrode OCP [V]"],
62+
},
63+
check_already_exists=False,
64+
)
65+
modeltest = tests.StandardModelTest(model, parameter_values=parameter_values)
66+
modeltest.test_all(skip_output_tests=True)
5667

5768
def test_voltage_control(self):
5869
options = {"operating mode": "voltage"}

0 commit comments

Comments
 (0)