#2643 tidy up debug code

Author: martinjrobins

pybamm/solvers/c_solvers/idaklu/casadi_sundials_functions.cpp

@@ -151,15 +151,13 @@ int jacobian_casadi(realtype tt, realtype cj, N_Vector yy, N_Vector yp,
   realtype *jac_data;
   if (p_python_functions->options.using_sparse_matrix)
   {
-    DEBUG("sparse jacobian_casadi");
     jac_data = SUNSparseMatrix_Data(JJ);
   }
   else if (p_python_functions->options.using_banded_matrix) {
     jac_data = p_python_functions->get_tmp_sparse_jacobian_data();
   }
   else
   {
-    DEBUG("dense jacobian_casadi");
     jac_data = SUNDenseMatrix_Data(JJ);
   }
 
@@ -177,16 +175,14 @@ int jacobian_casadi(realtype tt, realtype cj, N_Vector yy, N_Vector yp,
   if (p_python_functions->options.using_banded_matrix) 
   {
     // copy data from temporary matrix to the banded matrix
-    DEBUG("banded jacobian_casadi");
-    realtype *ret_jac_data = SUNBandMatrix_Data(JJ);
     auto jac_colptrs = p_python_functions->jac_times_cjmass_colptrs.data();
     auto jac_rowvals = p_python_functions->jac_times_cjmass_rowvals.data();
-    auto ncols = p_python_functions->number_of_states;
+    int ncols = p_python_functions->number_of_states;
     for (int col_ij = 0; col_ij < ncols; col_ij++) {
-      auto banded_col = SM_COLUMN_B(JJ, col_ij);
+      realtype *banded_col = SM_COLUMN_B(JJ, col_ij);
       for (auto data_i = jac_colptrs[col_ij]; data_i < jac_colptrs[col_ij+1]; data_i++) {
         auto row_ij = jac_rowvals[data_i];
-        auto value_ij = jac_data[data_i];
+        const realtype value_ij = jac_data[data_i];
         DEBUG("(" << row_ij << ", " << col_ij << ") = " << value_ij);
         SM_COLUMN_ELEMENT_B(banded_col, row_ij, col_ij) = value_ij;
       }