Skip to content

Commit ef8571c

Browse files
authored
fix ec reaction bug (#4774)
fix bugs
1 parent c9cb2bb commit ef8571c

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/pybamm/models/submodels/interface/sei/sei_growth.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,6 @@ def get_coupled_variables(self, variables):
186186
# j = -F * c_0* k_exp() / (1 + L * k_exp() / D)
187187
# c_ec = c_0 - L * k_exp() / D / (1 + L * k_exp() / D)
188188
# = c_0 / (1 + L * k_exp() / D)
189-
eta_SEI = delta_phi
190189
k_exp = phase_param.k_sei * pybamm.exp(-alpha_SEI * F_RT * eta_SEI)
191190
L_over_D = L_sei / phase_param.D_ec
192191
c_0 = phase_param.c_ec_0

src/pybamm/simulation.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -895,7 +895,6 @@ def solve(
895895
logs["summary variables"] = cycle_sum_vars
896896

897897
# Calculate capacity_start using the first cycle
898-
capacity_stop = None
899898
if cycle_num == 1:
900899
# Note capacity_start could be defined as
901900
# self._parameter_values["Nominal cell capacity [A.h]"] instead
@@ -907,6 +906,8 @@ def solve(
907906
capacity_stop = value
908907
elif typ == "%":
909908
capacity_stop = value / 100 * capacity_start
909+
else:
910+
capacity_stop = None
910911
logs["stopping conditions"]["capacity"] = capacity_stop
911912

912913
logs["elapsed time"] = timer.time()

0 commit comments

Comments
 (0)