#2358 fixed flake8 issues

Author: Scottmar93

pybamm/experiments/experiment.py

@@ -33,17 +33,17 @@ class Experiment:
     list of operating conditions should be passed in. Each operating condition should
     be of the form "Do this for this long" or "Do this until this happens". For example,
     "Charge at 1 C for 1 hour", or "Charge at 1 C until 4.2 V", or "Charge at 1 C for 1
-    hour or until 4.2 V at 25oC". The instructions can be of the form 
-    "(Dis)charge at x A/C/W", "Rest", or "Hold at x V until y A at z degC". The running 
+    hour or until 4.2 V at 25oC". The instructions can be of the form
+    "(Dis)charge at x A/C/W", "Rest", or "Hold at x V until y A at z degC". The running
     time should be a time in seconds, minutes or
     hours, e.g. "10 seconds", "3 minutes" or "1 hour". The stopping conditions should be
     a circuit state, e.g. "1 A", "C/50" or "3 V". The parameter drive_cycles is
     mandatory to run drive cycle. For example, "Run x", then x must be the key
-    of drive_cycles dictionary. The temperature should be provided after the stopping 
-    condition but before the period, e.g. "1 A at 25 degC (1 second period)". It is 
+    of drive_cycles dictionary. The temperature should be provided after the stopping
+    condition but before the period, e.g. "1 A at 25 degC (1 second period)". It is
     not essential to provide a temperature and a global temperature can be set either
-    from within the paramter values of passing a temperature to this experiment class. 
-    If the temperature is not specified in a line, then the global temperature is used, 
+    from within the paramter values of passing a temperature to this experiment class.
+    If the temperature is not specified in a line, then the global temperature is used,
     even if another temperature has been set in an earlier line.
 
     Parameters
@@ -217,7 +217,7 @@ def read_string(self, cond, drive_cycles):
         # Read instructions
         if "Run" in cond:
             cond_list = cond.split()
-            if not "degC" in cond and not "oC" in cond:
+            if "degC" not in cond and "oC" not in cond:
                 if "at" in cond:
                     raise ValueError(f"Instruction must be of the form: {examples}")
             dc_types = ["(A)", "(V)", "(W)"]

pybamm/parameters/ecm_parameters.py

@@ -47,7 +47,9 @@ def _set_initial_condition_parameters(self):
         self.initial_T_jig = pybamm.Parameter("Initial temperature [K]") - 273.15
 
     def T_amb(self, t):
-        ambient_temperature_K = pybamm.FunctionParameter("Ambient temperature [K]", {"Time [s]": t})
+        ambient_temperature_K = pybamm.FunctionParameter(
+            "Ambient temperature [K]", {"Time [s]": t}
+        )
         return ambient_temperature_K - 273.15
 
     def ocv(self, soc):

pybamm/simulation.py

@@ -370,10 +370,12 @@ def get_experiment_parameter_values(self, op, op_number):
             experiment_parameter_values.update(
                 {"Ambient temperature [K]": ambient_temperature}
             )
-            if op_number == 0: 
-                experiment_parameter_values.update({
-                    "Initial temperature [K]": ambient_temperature,
-                })
+            if op_number == 0:
+                experiment_parameter_values.update(
+                    {
+                        "Initial temperature [K]": ambient_temperature,
+                    }
+                )
         else:
             experiment_parameter_values.update(
                 {"Ambient temperature [K]": self._original_temperature}

tests/unit/test_experiments/test_experiment.py

@@ -243,7 +243,8 @@ def test_read_strings_cccv_combined(self):
                 "period": 60.0,
                 "temperature": 32.0,
                 "dc_data": None,
-                "string": "Charge at 0.5 C until 1V at 32 degC then hold at 1V until C/50 at 32 degC",
+                "string": "Charge at 0.5 C until 1V at 32 degC "
+                "then hold at 1V until C/50 at 32 degC",
                 "events": {"C-rate input [-]": 0.02, "type": "C-rate"},
             },
             {