Question about including variables in model.rhs

[YouHyin]

I want to set the discharge capacity limit. (ex. Charge at 1C until 0.88 A.h)
So I added this code in def update_new_model_events.(https://github.com/pybamm-team/PyBaMM/blob/main/pybamm/simulation.py)
if "Capacity cut-off [A.h]" in op:
new_model.events.append(
pybamm.Event(
"Capacity cut-off (CCCV) [A] [experiment]",
(
new_model.variables["Discharge capacity [A.h]"]
< (pybamm.InputParameter("Capacity input [A.h]") - 1e-4)
),
)
)

I want to include variable 'Discharge capacity [A.h]' in model.rhs or model.algebraic.
However, I don't know which code to add in model.rhs.
Should I add in basemodel.py ??(https://github.com/pybamm-team/PyBaMM/blob/main/pybamm/models/base_model.py)

Thank you!

[RuiheLi]

Hi, I think this may be linked to the fact that the model in model.rhs is not the same model and by the time it is created, it doesn't contain the variables we need, i.e., "Discharge capacity [A.h]", the key script may be this. No sure how to solve this, would you have some quick ideas? @brosaplanella