Conversation
✅ Deploy Preview for pybamm-developer-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for pybamm-developer-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Should we make this a scrollable gallery? But otherwise, the changes from my review below will make it look like this:
and then the size of the logos can be bumped again. Edit: we could get the dark mode logos for these orgs and unis too and skip the white background (feels a little out of place, personally)
| <h2>Trusted by top battery researchers and engineers</h2> | ||
| </div> | ||
|
|
||
| <div style="display:flex; justify-content:space-around; align-items:center; flex-wrap:wrap"> |
There was a problem hiding this comment.
| <div style="display:flex; justify-content:space-around; align-items:center; flex-wrap:wrap"> | |
| <div style="display:flex; justify-content:space-around; align-items:center; flex-wrap:wrap; background:white; border-radius:0.5em 0.5em 0 0"> |
Something like this should fix the backgrounds so that this gallery has a white one. This should also wrap them in a slightly rounded border
There was a problem hiding this comment.
What's weird is that the images themselves have transparent backgrounds, so they should be fine on a black background
There was a problem hiding this comment.
We could also remove the light/dark mode and always use light mode
There was a problem hiding this comment.
I figured it out – it's because of the figure shortcode we are using, which is setting the background to white. I checked https://theme.scientific-python.org/shortcodes/#figure for ways to configure this, but there are none. Perhaps we can use regular HTML to add the images.
There was a problem hiding this comment.
For light mode, I see that NumPy permanently sets it to white, while SciPy does not. I'll try to find out how.
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
4 participants
Move logos from unfindable page to more prominent position on front page
There is a problem with the backgrounds and I haven't been able to fix it yet
