PyBOP with custom models from PyBaMM

[isaacbasil]

Hi,

I am wanting to optimise parameters for a custom model which I have build in PyBaMM. Is PyBOP appropriate for this, or is it currently suitable only for the standard models included in PyBaMM?

Cheers,

Isaac

[NicolaCourtier]

Hi @isaacbasil

We are currently undergoing a restructure to allow this (see #699).

At the moment, your custom PyBaMM model would require wrapping to make it compatible. I probably shouldn't suggest this, but you may get somewhere with, e.g.

model = pybop.empirical.ECircuitModel(
    pybamm_model=pybamm.equivalent_circuit.Thevenin,
    name="Custom ECM",
    options={"number of rc elements": 2},
    parameter_set=parameter_set,
)

But if you are working with geometric parameters (which require a PyBaMM model rebuild) then you would need to take care to also set the geometric_parameters to trigger the rebuilding.

That said, I would advise waiting for the restructure.

[isaacbasil]

Hi Nicola,

Thanks for your quick response. I just gave it a try with that approach but ran into several other problems, so as you suggested I'll revisit this once the restructure is done.

Cheers,

Isaac