Skip to content

Commit 428bca7

Browse files
committed
pybricks.common.Control: Document deadzone.
1 parent 0e8b6cf commit 428bca7

File tree

3 files changed

+11
-7
lines changed

3 files changed

+11
-7
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@
44

55
## Unreleased
66

7+
### Added
8+
- Documented ``integral_deadzone`` in ``Control.pid()``.
9+
710
## 3.2.0 - 2022-12-20
811

912
### Changed

jedi/tests/test_get_signature.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -637,12 +637,12 @@ def _get_method_signature(module: str, type: str, method: str) -> SignatureHelp:
637637
"kp: Optional[Number]=None",
638638
"ki: Optional[Number]=None",
639639
"kd: Optional[Number]=None",
640-
"reserved: Optional[Number]=None",
640+
"integral_deadzone: Optional[Number]=None",
641641
"integral_rate: Optional[Number]=None",
642642
],
643643
"None",
644644
),
645-
([], "Tuple[int, int, int, None, int]"),
645+
([], "Tuple[int, int, int, int, int]"),
646646
],
647647
),
648648
pytest.param(

src/pybricks/_common.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -219,18 +219,18 @@ def pid(
219219
kp: Optional[Number] = None,
220220
ki: Optional[Number] = None,
221221
kd: Optional[Number] = None,
222-
reserved: Optional[Number] = None,
222+
integral_deadzone: Optional[Number] = None,
223223
integral_rate: Optional[Number] = None,
224224
) -> None:
225225
...
226226

227227
@overload
228-
def pid(self) -> Tuple[int, int, int, None, int]:
228+
def pid(self) -> Tuple[int, int, int, int, int]:
229229
...
230230

231231
def pid(self, *args):
232-
"""pid(kp, ki, kd, reserved, integral_rate)
233-
pid() -> Tuple[int, int, int, None, int]
232+
"""pid(kp, ki, kd, integral_deadzone, integral_rate)
233+
pid() -> Tuple[int, int, int, int, int]
234234
235235
Gets or sets the PID values for position and speed control.
236236
@@ -245,7 +245,8 @@ def pid(self, *args):
245245
kd (int): Derivative position (or proportional speed) control
246246
constant. It is the feedback torque per
247247
unit of speed: µNm/(deg/s).
248-
reserved: This setting is not used.
248+
integral_deadzone (Number, deg or Number, mm): Zone around the
249+
target where the error integral does not accumulate errors.
249250
integral_rate (Number, deg/s or Number, mm/s): Maximum rate at
250251
which the error integral is allowed to grow.
251252
"""

0 commit comments

Comments
 (0)