app: fix clipping of editor popups

dlech · dlech · commit 74f1619eb34d · 2022-12-27T17:35:11.000-06:00
Editor popups like the ones for code completion were getting clipped
by the layout pane containers.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,9 @@
 ### Changed
 - Improved syntax highlighting for f-strings, operators and numeric literals.
 
+### Fixed
+- Fixed clipping of code completion popup by terminal.
+
 ## [2.1.0-beta.2] - 2022-12-26
 
 ### Changed
diff --git a/src/app/app.scss b/src/app/app.scss
@@ -167,8 +167,10 @@ $dark-splitter-color-hover: color.adjust(
     }
 }
 
-.splitter-layout .layout-pane {
-    overflow: hidden;
+// we want overflow visible for editor overlays but it breaks resizing
+// so we can only apply this when not resizing
+.splitter-layout:not(.layout-changing) > .layout-pane {
+    overflow: visible;
 }
 
 // hide the docs and resize separator

Original file line number	Diff line number	Diff line change
`@@ -167,8 +167,10 @@ $dark-splitter-color-hover: color.adjust(`
`167`	`167`	`}`
`168`	`168`	`}`
`169`	`169`
`170`		`-.splitter-layout .layout-pane {`
`171`		`- overflow: hidden;`
	`170`	`+// we want overflow visible for editor overlays but it breaks resizing`
	`171`	`+// so we can only apply this when not resizing`
	`172`	`+.splitter-layout:not(.layout-changing) > .layout-pane {`
	`173`	`+ overflow: visible;`
`172`	`174`	`}`
`173`	`175`
`174`	`176`	`// hide the docs and resize separator`