Skip to content

Commit 7d5c971

Browse files
committed
editor/sagas: fix signature trigger characters
The intended behavior is that comma should trigger signature help when it is not showing. retrigger only triggers if already showing.
1 parent d119cb5 commit 7d5c971

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@
44

55
## [Unreleased]
66

7+
### Changed
8+
- Code completion trigger improvements.
9+
710
### Fixed
811
- Fixed terminal layout issues when resizing window vertically.
912
- Fixed editor find widget visible over modal dialogs.

src/editor/sagas.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -635,8 +635,8 @@ function* runJedi(): Generator {
635635
const subscription = monaco.languages.registerSignatureHelpProvider(
636636
pybricksMicroPythonId,
637637
{
638-
signatureHelpTriggerCharacters: ['('],
639-
signatureHelpRetriggerCharacters: [','],
638+
signatureHelpTriggerCharacters: ['(', ','],
639+
signatureHelpRetriggerCharacters: [')'],
640640
provideSignatureHelp(model, position, token, context) {
641641
return new Promise((resolve) => {
642642
emit({ model, position, token, context, resolve });

0 commit comments

Comments
 (0)