Skip to content

Commit 8db98a8

Browse files
committed
ev3: Don't request hardware version.
This feature doesn't seem to work when it is issued from a USB3 bus. See pybricks/support#2515. Since we don't use the version, removing the command is harmless.
1 parent 4516cc8 commit 8db98a8

File tree

1 file changed

+1
-23
lines changed

1 file changed

+1
-23
lines changed

src/firmware/sagas.ts

Lines changed: 1 addition & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// SPDX-License-Identifier: MIT
2-
// Copyright (c) 2020-2025 The Pybricks Authors
2+
// Copyright (c) 2020-2026 The Pybricks Authors
33

44
import {
55
FirmwareReader,
@@ -1204,28 +1204,6 @@ function* handleFlashEV3(action: ReturnType<typeof firmwareFlashEV3>): Generator
12041204
return [new DataView(reply.payload), undefined];
12051205
}
12061206

1207-
const [version, versionError] = yield* sendCommand(0xf6); // get version
1208-
1209-
if (versionError) {
1210-
yield* put(
1211-
alertsShowAlert('alerts', 'unexpectedError', {
1212-
error: ensureError(versionError),
1213-
}),
1214-
);
1215-
yield* put(firmwareDidFailToFlashEV3());
1216-
yield* cleanup();
1217-
return;
1218-
}
1219-
1220-
defined(version);
1221-
1222-
console.debug(
1223-
`EV3 bootloader version: ${version.getUint32(
1224-
0,
1225-
true,
1226-
)}, HW version: ${version.getUint32(4, true)}`,
1227-
);
1228-
12291207
// FIXME: should be called much earlier.
12301208
yield* put(didStart());
12311209

0 commit comments

Comments
 (0)