Skip to content

Commit 992923b

Browse files
committed
SponsorDialog: make team link inline
Also buttons cannot be inside of `<p>` tags.
1 parent 3e50e58 commit 992923b

File tree

2 files changed

+24
-16
lines changed

2 files changed

+24
-16
lines changed

src/sponsor/SponsorDialog.tsx

Lines changed: 20 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -30,14 +30,23 @@ const SponsorDialog: React.VoidFunctionComponent = () => {
3030
<div className={classNames(Classes.DIALOG_BODY, Classes.RUNNING_TEXT)}>
3131
<h4>{i18n.translate('whoAreWe.heading')}</h4>
3232
<p>
33-
{i18n.translate('whoAreWe.team')}{' '}
34-
<a href={pybricksTeamUrl} target="_blank" rel="noreferrer">
35-
{i18n.translate('whoAreWe.learnMore')}
36-
</a>
37-
<ExternalLinkIcon />
33+
{i18n.translate('whoAreWe.team.about', {
34+
team: (
35+
<>
36+
<a
37+
href={pybricksTeamUrl}
38+
target="_blank"
39+
rel="noreferrer"
40+
>
41+
{i18n.translate('whoAreWe.team.team')}
42+
</a>
43+
<ExternalLinkIcon />
44+
</>
45+
),
46+
})}
3847
</p>
39-
4048
<p>{i18n.translate('whoAreWe.mission')}</p>
49+
4150
<h4>{i18n.translate('whyDonate.heading')}</h4>
4251
<p>{i18n.translate('whyDonate.body')}</p>
4352
<p>
@@ -49,10 +58,13 @@ const SponsorDialog: React.VoidFunctionComponent = () => {
4958
<li>{i18n.translate('donateReason.supportOthers')}</li>
5059
</ul>
5160
</p>
61+
5262
<h4>{i18n.translate('donateOptions.heading')}</h4>
5363
<p>{i18n.translate('donateOptions.options')}</p>
5464
<p>{i18n.translate('donateOptions.thanks')}</p>
55-
<p>
65+
</div>
66+
<div className={Classes.DIALOG_FOOTER}>
67+
<div className={Classes.DIALOG_FOOTER_ACTIONS}>
5668
<AnchorButton
5769
large={true}
5870
intent={Intent.PRIMARY}
@@ -65,8 +77,6 @@ const SponsorDialog: React.VoidFunctionComponent = () => {
6577
GitHub Sponsors
6678
<ExternalLinkIcon />
6779
</AnchorButton>
68-
</p>
69-
<p>
7080
<AnchorButton
7181
large={true}
7282
intent={Intent.PRIMARY}
@@ -79,8 +89,6 @@ const SponsorDialog: React.VoidFunctionComponent = () => {
7989
Patreon
8090
<ExternalLinkIcon />
8191
</AnchorButton>
82-
</p>
83-
<p>
8492
<AnchorButton
8593
large={true}
8694
intent={Intent.PRIMARY}
@@ -93,8 +101,6 @@ const SponsorDialog: React.VoidFunctionComponent = () => {
93101
Paypal
94102
<ExternalLinkIcon />
95103
</AnchorButton>
96-
</p>
97-
<p>
98104
<AnchorButton
99105
large={true}
100106
intent={Intent.PRIMARY}
@@ -103,7 +109,7 @@ const SponsorDialog: React.VoidFunctionComponent = () => {
103109
>
104110
pybricks.eth
105111
</AnchorButton>
106-
</p>
112+
</div>
107113
</div>
108114
</Dialog>
109115
);

src/sponsor/translations/en.json

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,10 @@
22
"title": "Sponsor {pybricks}",
33
"whoAreWe": {
44
"heading": "Who are we?",
5-
"team": "Pybricks is run by a small team, supported by a community of open source coding enthusiasts from all around the world.",
6-
"learnMore": "Learn more.",
5+
"team": {
6+
"about": "Pybricks is run by a small {team}, supported by a community of open source coding enthusiasts from all around the world.",
7+
"team": "team"
8+
},
79
"mission": "Our mission is to make robotics fun and accessible and teach a million people how to code. And you can help!"
810
},
911
"whyDonate": {

0 commit comments

Comments
 (0)