Skip to content

Commit a70010e

Browse files
jaguilardlech
authored andcommitted
ev3: Don't request hardware version.
This feature doesn't seem to work when it is issued from a USB3 bus. See pybricks/support#2515. Since we don't use the version, removing the command is harmless.
1 parent 8db1a27 commit a70010e

File tree

1 file changed

+1
-23
lines changed

1 file changed

+1
-23
lines changed

src/firmware/sagas.ts

Lines changed: 1 addition & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// SPDX-License-Identifier: MIT
2-
// Copyright (c) 2020-2025 The Pybricks Authors
2+
// Copyright (c) 2020-2026 The Pybricks Authors
33

44
import {
55
FirmwareReader,
@@ -1206,28 +1206,6 @@ function* handleFlashEV3(action: ReturnType<typeof firmwareFlashEV3>): Generator
12061206
return [new DataView(reply.payload), undefined];
12071207
}
12081208

1209-
const [version, versionError] = yield* sendCommand(0xf6); // get version
1210-
1211-
if (versionError) {
1212-
yield* put(
1213-
alertsShowAlert('alerts', 'unexpectedError', {
1214-
error: ensureError(versionError),
1215-
}),
1216-
);
1217-
yield* put(firmwareDidFailToFlashEV3());
1218-
yield* cleanup();
1219-
return;
1220-
}
1221-
1222-
defined(version);
1223-
1224-
console.debug(
1225-
`EV3 bootloader version: ${version.getUint32(
1226-
0,
1227-
true,
1228-
)}, HW version: ${version.getUint32(4, true)}`,
1229-
);
1230-
12311209
// FIXME: should be called much earlier.
12321210
yield* put(didStart());
12331211

0 commit comments

Comments
 (0)