more code coverage

Author: dlech

src/alerts/UnexpectedErrorAlert.test.tsx

@@ -0,0 +1,18 @@
+// SPDX-License-Identifier: MIT
+// Copyright (c) 2022-2023 The Pybricks Authors
+
+import { Toast } from '@blueprintjs/core';
+import React from 'react';
+import { testRender } from '../../test';
+import { unexpectedError } from './UnexpectedErrorAlert';
+
+it('should dismiss when close is clicked', async () => {
+    const callback = jest.fn();
+    const toast = unexpectedError(callback, { error: new Error('test') });
+
+    const [user, message] = testRender(<Toast {...toast} />);
+
+    await user.click(message.getByRole('button', { name: /close/i }));
+
+    expect(callback).toHaveBeenCalledWith('dismiss');
+});

src/app/alerts/UpdateServerFailure.test.tsx

@@ -0,0 +1,18 @@
+// SPDX-License-Identifier: MIT
+// Copyright (c) 2022-2023 The Pybricks Authors
+
+import { Toast } from '@blueprintjs/core';
+import React from 'react';
+import { testRender } from '../../../test';
+import { updateServerFailure } from './UpdateServerFailure';
+
+it('should dismiss when close is clicked', async () => {
+    const callback = jest.fn();
+    const toast = updateServerFailure(callback, undefined as never);
+
+    const [user, message] = testRender(<Toast {...toast} />);
+
+    await user.click(message.getByRole('button', { name: /close/i }));
+
+    expect(callback).toHaveBeenCalledWith('dismiss');
+});

src/ble/alerts/BluetoothNotAvailable.test.tsx

@@ -0,0 +1,18 @@
+// SPDX-License-Identifier: MIT
+// Copyright (c) 2022-2023 The Pybricks Authors
+
+import { Toast } from '@blueprintjs/core';
+import React from 'react';
+import { testRender } from '../../../test';
+import { bluetoothNotAvailable } from './BluetoothNotAvailable';
+
+it('should dismiss when close is clicked', async () => {
+    const callback = jest.fn();
+    const toast = bluetoothNotAvailable(callback, undefined as never);
+
+    const [user, message] = testRender(<Toast {...toast} />);
+
+    await user.click(message.getByRole('button', { name: /close/i }));
+
+    expect(callback).toHaveBeenCalledWith('dismiss');
+});

src/ble/alerts/MissingService.test.tsx

@@ -0,0 +1,18 @@
+// SPDX-License-Identifier: MIT
+// Copyright (c) 2022-2023 The Pybricks Authors
+
+import { Toast } from '@blueprintjs/core';
+import React from 'react';
+import { testRender } from '../../../test';
+import { missingService } from './MissingService';
+
+it('should dismiss when close is clicked', async () => {
+    const callback = jest.fn();
+    const toast = missingService(callback, { hubName: 'name', serviceName: 'service' });
+
+    const [user, message] = testRender(<Toast {...toast} />);
+
+    await user.click(message.getByRole('button', { name: /close/i }));
+
+    expect(callback).toHaveBeenCalledWith('dismiss');
+});

src/ble/alerts/NoGatt.test.tsx

@@ -0,0 +1,18 @@
+// SPDX-License-Identifier: MIT
+// Copyright (c) 2022-2023 The Pybricks Authors
+
+import { Toast } from '@blueprintjs/core';
+import React from 'react';
+import { testRender } from '../../../test';
+import { noGatt } from './NoGatt';
+
+it('should dismiss when close is clicked', async () => {
+    const callback = jest.fn();
+    const toast = noGatt(callback, undefined as never);
+
+    const [user, message] = testRender(<Toast {...toast} />);
+
+    await user.click(message.getByRole('button', { name: /close/i }));
+
+    expect(callback).toHaveBeenCalledWith('dismiss');
+});

src/ble/alerts/NoHub.test.tsx

@@ -0,0 +1,29 @@
+// SPDX-License-Identifier: MIT
+// Copyright (c) 2022-2023 The Pybricks Authors
+
+import { Toast } from '@blueprintjs/core';
+import React from 'react';
+import { testRender } from '../../../test';
+import { noHub } from './NoHub';
+
+it('should dismiss when close is clicked', async () => {
+    const callback = jest.fn();
+    const toast = noHub(callback, undefined as never);
+
+    const [user, message] = testRender(<Toast {...toast} />);
+
+    await user.click(message.getByRole('button', { name: /close/i }));
+
+    expect(callback).toHaveBeenCalledWith('dismiss');
+});
+
+it('should flash firmware when button is clicked', async () => {
+    const callback = jest.fn();
+    const toast = noHub(callback, undefined as never);
+
+    const [user, message] = testRender(<Toast {...toast} />);
+
+    await user.click(message.getByRole('button', { name: /firmware/i }));
+
+    expect(callback).toHaveBeenCalledWith('flashFirmware');
+});

src/ble/alerts/NoWebBluetooth.test.tsx

@@ -0,0 +1,18 @@
+// SPDX-License-Identifier: MIT
+// Copyright (c) 2022-2023 The Pybricks Authors
+
+import { Toast } from '@blueprintjs/core';
+import React from 'react';
+import { testRender } from '../../../test';
+import { noWebBluetooth } from './NoWebBluetooth';
+
+it('should dismiss when close is clicked', async () => {
+    const callback = jest.fn();
+    const toast = noWebBluetooth(callback, undefined as never);
+
+    const [user, message] = testRender(<Toast {...toast} />);
+
+    await user.click(message.getByRole('button', { name: /close/i }));
+
+    expect(callback).toHaveBeenCalledWith('dismiss');
+});

src/ble/alerts/OldFimrware.test.tsx

@@ -0,0 +1,29 @@
+// SPDX-License-Identifier: MIT
+// Copyright (c) 2022-2023 The Pybricks Authors
+
+import { Toast } from '@blueprintjs/core';
+import React from 'react';
+import { testRender } from '../../../test';
+import { oldFirmware } from './OldFirmware';
+
+it('should dismiss when close is clicked', async () => {
+    const callback = jest.fn();
+    const toast = oldFirmware(callback, undefined as never);
+
+    const [user, message] = testRender(<Toast {...toast} />);
+
+    await user.click(message.getByRole('button', { name: /close/i }));
+
+    expect(callback).toHaveBeenCalledWith('dismiss');
+});
+
+it('should flash firmware when button is clicked', async () => {
+    const callback = jest.fn();
+    const toast = oldFirmware(callback, undefined as never);
+
+    const [user, message] = testRender(<Toast {...toast} />);
+
+    await user.click(message.getByRole('button', { name: /firmware/i }));
+
+    expect(callback).toHaveBeenCalledWith('flashFirmware');
+});

src/blueprintjs-icons.js

@@ -4,6 +4,8 @@
 // HACK: Prevent webpack from picking up all icons.
 // https://github.com/palantir/blueprint/issues/2193
 
+// istanbul ignore file
+
 import {
     Add,
     Archive,

src/explorer/alerts/FileInUseAlert.test.tsx

@@ -1,21 +1,18 @@
 // SPDX-License-Identifier: MIT
-// Copyright (c) 2022 The Pybricks Authors
+// Copyright (c) 2022-2023 The Pybricks Authors
 
+import { Toast } from '@blueprintjs/core';
 import React from 'react';
 import { testRender } from '../../../test';
 import { fileInUse } from './FileInUseAlert';
 
-it('should be valid', () => {
+it('should dismiss when close is clicked', async () => {
     const callback = jest.fn();
     const toast = fileInUse(callback, { fileName: 'test.file' });
 
-    // TODO: refactor this to a common function to be used by all alerts
+    const [user, message] = testRender(<Toast {...toast} />);
 
-    // it should render
-    const [, message] = testRender(<>{toast.message}</>);
-    expect(message).toBeDefined();
+    await user.click(message.getByRole('button', { name: /close/i }));
 
-    // it should have a dismiss callback
-    toast.onDismiss?.(false);
     expect(callback).toHaveBeenCalledWith('dismiss');
 });