Skip to content

Commit ca50d60

Browse files
committed
app: fix vertical resizing issues
Some new issues with layout when resizing the browser window vertically were caused either by recent xterm updates or other recent style changes. This works around those issues.
1 parent 594bd04 commit ca50d60

File tree

2 files changed

+14
-1
lines changed

2 files changed

+14
-1
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@
44

55
## [Unreleased]
66

7+
### Fixed
8+
- Fixed terminal layout issues when resizing window vertically.
9+
710
## [2.1.0-beta.3] - 2022-12-28
811

912
### Changed

src/app/app.scss

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,10 +169,20 @@ $dark-splitter-color-hover: color.adjust(
169169

170170
// we want overflow visible for editor overlays but it breaks resizing
171171
// so we can only apply this when not resizing
172-
.splitter-layout:not(.layout-changing) > .layout-pane {
172+
.splitter-layout:not(.layout-changing) > .layout-pane:has(.pb-app-editor) {
173173
overflow: visible;
174174
}
175175

176+
.splitter-layout .layout-pane {
177+
// fix double scroll bars in terminal when resizing
178+
overflow: hidden;
179+
180+
&.layout-pane-primary {
181+
// fix resizing window vertically
182+
min-height: 0;
183+
}
184+
}
185+
176186
// hide the docs and resize separator
177187

178188
div.pb-hide-docs > :not(.layout-pane-primary) {

0 commit comments

Comments
 (0)