drv/led: move internals to separate header file

This makes the intent clearer and discourages improper use of the API.

Author: dlech

lib/pbio/drv/core.c

@@ -4,9 +4,9 @@
 #include <contiki.h>
 
 #include <pbdrv/battery.h>
-#include <pbdrv/led.h>
 
 #include "counter/counter.h"
+#include "led/led.h"
 #include "pwm/pwm.h"
 
 /** Initializes all enabled drivers. */

lib/pbio/drv/led/led.h

@@ -0,0 +1,36 @@
+// SPDX-License-Identifier: MIT
+// Copyright (c) 2020 The Pybricks Authors
+
+// LED driver internal types and functions
+
+#ifndef _PBDRV_LED_LED_H_
+#define _PBDRV_LED_LED_H_
+
+#include <pbdrv/config.h>
+#include <pbdrv/led.h>
+#include <pbio/color.h>
+#include <pbio/error.h>
+
+typedef struct {
+    pbio_error_t (*set_hsv)(pbdrv_led_dev_t *dev, const pbio_color_hsv_t *hsv);
+} pbdrv_led_funcs_t;
+
+/** LED device instance. */
+struct _pbdrv_led_dev_t {
+    /** Platform-specific data */
+    const void *pdata;
+    /** Driver-specific callbacks. */
+    const pbdrv_led_funcs_t *funcs;
+};
+
+#if PBDRV_CONFIG_LED
+
+void pbdrv_led_init();
+
+#else // PBDRV_CONFIG_LED
+
+#define pbdrv_led_init()
+
+#endif // PBDRV_CONFIG_LED
+
+#endif // _PBDRV_LED_LED_H_

lib/pbio/drv/led/led_core.c

@@ -15,6 +15,7 @@
 #include "led_dual.h"
 #include "led_ev3dev.h"
 #include "led_pwm.h"
+#include "led.h"
 
 #ifndef PBDRV_CONFIG_LED_NUM_DEV
 #error "Must define PBDRV_CONFIG_LED_NUM_DEV"

lib/pbio/drv/led/led_dual.c

@@ -17,6 +17,7 @@
 #include <pbio/math.h>
 
 #include "led_dual.h"
+#include "led.h"
 
 #ifndef PBDRV_CONFIG_LED_DUAL_NUM_DEV
 #error "Must define PBDRV_CONFIG_LED_DUAL_NUM_DEV"

lib/pbio/drv/led/led_ev3dev.c

@@ -15,6 +15,7 @@
 #include <pbio/error.h>
 
 #include "led_ev3dev.h"
+#include "led.h"
 
 #define NUM_LEDS 4
 

lib/pbio/drv/led/led_pwm.c

@@ -17,6 +17,7 @@
 #include <pbio/math.h>
 
 #include "led_pwm.h"
+#include "led.h"
 
 #ifndef PBDRV_CONFIG_LED_PWM_NUM_DEV
 #error "Must define PBDRV_CONFIG_LED_PWM_NUM_DEV"

lib/pbio/include/pbdrv/led.h

@@ -19,32 +19,14 @@
 
 typedef struct _pbdrv_led_dev_t pbdrv_led_dev_t;
 
-typedef struct {
-    pbio_error_t (*set_hsv)(pbdrv_led_dev_t *dev, const pbio_color_hsv_t *hsv);
-} pbdrv_led_funcs_t;
-
-/** LED device instance. */
-struct _pbdrv_led_dev_t {
-    /** Platform-specific data */
-    const void *pdata;
-    /** Driver-specific callbacks. */
-    const pbdrv_led_funcs_t *funcs;
-};
-
 #if PBDRV_CONFIG_LED
 
-/** @cond INTERNAL */
-void pbdrv_led_init();
-/** @endcond */
-
 pbio_error_t pbdrv_led_get_dev(uint8_t id, pbdrv_led_dev_t **dev);
 pbio_error_t pbdrv_led_set_hsv(pbdrv_led_dev_t *dev, const pbio_color_hsv_t *hsv);
 pbio_error_t pbdrv_led_on(pbdrv_led_dev_t *dev, pbio_color_t color);
 pbio_error_t pbdrv_led_off(pbdrv_led_dev_t *dev);
 
-#else
-
-#define pbdrv_led_init()
+#else // PBDRV_CONFIG_LED
 
 static inline pbio_error_t pbdrv_led_get_dev(uint8_t id, pbdrv_led_dev_t **dev) {
     *dev = NULL;
@@ -63,7 +45,7 @@ static inline pbio_error_t pbdrv_led_off(pbdrv_led_dev_t *dev) {
     return PBIO_ERROR_NOT_SUPPORTED;
 }
 
-#endif
+#endif // PBDRV_CONFIG_LED
 
 #endif // _PBDRV_LED_H_