pbio/sys/light: Don't pass unused status data around.

This was passed to the light status update function, but it does the same
regardless of setting or clearing.

This is not related to the pbsys_status_set function, which takes a bool for
set/clear. So pbsys_status_change_t made things a bit confusing now that it is
no longer used.

Author: laurensvalk

lib/pbio/include/pbsys/status.h

@@ -16,16 +16,6 @@
 
 #define PBSYS_STATUS_REPORT_SIZE 7
 
-/**
- * Status flag change.
- */
-typedef enum {
-    /** System status indicator was set. */
-    PBSYS_STATUS_CHANGE_SET,
-    /** System status indicator was cleared. */
-    PBSYS_STATUS_CHANGE_CLEARED,
-} pbsys_status_change_t;
-
 void pbsys_status_set_program_id(pbio_pybricks_user_program_id_t program_id);
 void pbsys_status_set(pbio_pybricks_status_t status);
 void pbsys_status_clear(pbio_pybricks_status_t status);

lib/pbio/sys/hmi.c

@@ -42,10 +42,6 @@ void pbsys_hmi_init(void) {
     pbsys_hub_light_matrix_init();
 }
 
-void pbsys_hmi_handle_status_change(pbsys_status_change_t event, pbio_pybricks_status_t data) {
-    pbsys_status_light_handle_status_change(event, data);
-}
-
 /**
  * Polls the HMI.
  *

lib/pbio/sys/hmi.h

@@ -8,7 +8,6 @@
 #include <pbsys/status.h>
 
 void pbsys_hmi_init(void);
-void pbsys_hmi_handle_status_change(pbsys_status_change_t event, pbio_pybricks_status_t data);
 void pbsys_hmi_poll(void);
 pbio_error_t pbsys_hmi_await_program_selection(void);
 

lib/pbio/sys/light.c

@@ -182,7 +182,7 @@ void pbsys_status_light_init(void) {
     #endif
 }
 
-static void pbsys_status_light_update_patterns(void) {
+void pbsys_status_light_handle_status_change(void) {
 
     // Warning pattern precedence.
     pbsys_status_light_indication_warning_t warning_indication = PBSYS_STATUS_LIGHT_INDICATION_WARNING_NONE;
@@ -222,12 +222,6 @@ static void pbsys_status_light_update_patterns(void) {
     }
 }
 
-void pbsys_status_light_handle_status_change(pbsys_status_change_t event, pbio_pybricks_status_t data) {
-    if (event == PBSYS_STATUS_CHANGE_SET || event == PBSYS_STATUS_CHANGE_CLEARED) {
-        pbsys_status_light_update_patterns();
-    }
-}
-
 /**
  * Advances the light to the next state in the pattern.
  *

lib/pbio/sys/light.h

@@ -11,11 +11,11 @@
 
 #if PBSYS_CONFIG_STATUS_LIGHT
 void pbsys_status_light_init(void);
-void pbsys_status_light_handle_status_change(pbsys_status_change_t event, pbio_pybricks_status_t data);
+void pbsys_status_light_handle_status_change(void);
 void pbsys_status_light_poll(void);
 #else
 #define pbsys_status_light_init()
-#define pbsys_status_light_handle_status_change(event, data)
+#define pbsys_status_light_handle_status_change()
 #define pbsys_status_light_poll()
 #endif
 

lib/pbio/sys/status.c

@@ -15,6 +15,7 @@
 #include <pbsys/status.h>
 
 #include "hmi.h"
+#include "light.h"
 
 static struct {
     /** Status indications as bit flags */
@@ -38,10 +39,10 @@ static void pbsys_status_update_flag(pbio_pybricks_status_t status, bool set) {
     pbsys_status.flags = new_flags;
     pbsys_status.changed_time[status] = pbdrv_clock_get_ms();
 
-    // hmi is the only subscriber to status changes, so call its handler
+    // status light is the only subscriber to status changes, so call its handler
     // directly. All other processes just poll the status as needed. If we ever
     // need more subscribers, we could register callbacks and call them here.
-    pbsys_hmi_handle_status_change(set ? PBSYS_STATUS_CHANGE_SET : PBSYS_STATUS_CHANGE_CLEARED, status);
+    pbsys_status_light_handle_status_change();
 
     // Other processes may be awaiting status changes, so poll.
     pbio_os_request_poll();