pbio/sys/status: Drop duplicate size constant.

This is a protocol constant, so we don't need to hardcode something of the same
value elsewhere and then statically assert equality.

Author: laurensvalk

lib/pbio/drv/usb/usb_stm32.c

@@ -36,7 +36,7 @@ PROCESS(pbdrv_usb_process, "USB");
 // to/from FIFOs in 32-bit chunks.
 static uint8_t usb_in_buf[USBD_PYBRICKS_MAX_PACKET_SIZE] __aligned(4);
 static uint8_t usb_response_buf[PBIO_PYBRICKS_USB_MESSAGE_SIZE(sizeof(uint32_t))] __aligned(4);
-static uint8_t usb_status_buf[PBIO_PYBRICKS_USB_MESSAGE_SIZE(PBSYS_STATUS_REPORT_SIZE)] __aligned(4);
+static uint8_t usb_status_buf[PBIO_PYBRICKS_USB_MESSAGE_SIZE(PBIO_PYBRICKS_EVENT_STATUS_REPORT_SIZE)] __aligned(4);
 static uint8_t usb_stdout_buf[USBD_PYBRICKS_MAX_PACKET_SIZE] __aligned(4);
 static volatile uint32_t usb_in_sz;
 static volatile uint32_t usb_response_sz;

lib/pbio/include/pbsys/status.h

@@ -14,8 +14,6 @@
 
 #include <pbio/protocol.h>
 
-#define PBSYS_STATUS_REPORT_SIZE 7
-
 void pbsys_status_set_program_id(pbio_pybricks_user_program_id_t program_id);
 void pbsys_status_set(pbio_pybricks_status_flags_t status);
 void pbsys_status_clear(pbio_pybricks_status_flags_t status);

lib/pbio/sys/status.c

@@ -56,16 +56,12 @@ static void pbsys_status_update_flag(pbio_pybricks_status_flags_t status, bool s
 /**
  * Gets the Pybricks status report and writes it to @p buf.
  *
- * The buffer must be at least ::PBSYS_STATUS_REPORT_SIZE bytes.
+ * The buffer must be at least ::PBIO_PYBRICKS_EVENT_STATUS_REPORT_SIZE bytes.
  *
  * @param [in]  buf        The buffer to hold the binary data.
  * @return                 The number of bytes written to @p buf.
  */
 uint32_t pbsys_status_get_status_report(uint8_t *buf) {
-
-    _Static_assert(PBSYS_STATUS_REPORT_SIZE == PBIO_PYBRICKS_EVENT_STATUS_REPORT_SIZE,
-        "size of status report does not match size of event");
-
     return pbio_pybricks_event_status_report(buf, pbsys_status.flags, pbsys_status.program_id, pbsys_status.slot);
 }