pybricks/util_mp: Optimize array test.

Using a utility saves a few more bytes on MoveHub and makes the code easier to follow.

Author: laurensvalk

pybricks/common/pb_type_ble.c

@@ -276,7 +276,7 @@ STATIC mp_obj_t pb_module_ble_broadcast(size_t n_args, const mp_obj_t *pos_args,
     mp_obj_t *objs;
     size_t n_objs;
     size_t index;
-    if (mp_obj_is_type(data_in, &mp_type_tuple) || mp_obj_is_type(data_in, &mp_type_list)) {
+    if (pb_obj_is_array(data_in)) {
         index = 0;
         mp_obj_get_array(data_in, &n_objs, &objs);
     } else {

pybricks/common/pb_type_control.c

@@ -33,7 +33,7 @@ void unpack_acceleration_value(mp_obj_t accel_in, int32_t *acceleration, int32_t
     }
 
     // If single value is given for acceleration, use it for deceleration too.
-    if (mp_obj_is_int(accel_in) || mp_obj_is_float(accel_in)) {
+    if (!pb_obj_is_array(accel_in)) {
         *acceleration = pb_obj_get_int(accel_in);
         *deceleration = *acceleration;
         return;

pybricks/robotics/pb_type_car.c

@@ -78,7 +78,7 @@ STATIC mp_obj_t pb_type_Car_make_new(const mp_obj_type_t *type, size_t n_args, s
     // Should be one motor for steering.
     self->srv_steer = pb_type_motor_get_servo(steer_motor_in);
 
-    if (mp_obj_is_type(drive_motors_in, &mp_type_tuple) || mp_obj_is_type(drive_motors_in, &mp_type_list)) {
+    if (pb_obj_is_array(drive_motors_in)) {
         // Unpack the drive motors if multiple are given.
         mp_obj_t *drive_motors;
         mp_obj_get_array(drive_motors_in, &self->n_drive, &drive_motors);

pybricks/util_mp/pb_obj_helper.c

@@ -124,6 +124,16 @@ mp_int_t pb_obj_get_default_abs_int(mp_obj_t obj, mp_int_t default_val) {
     return value > 0 ? value: -value;
 }
 
+/**
+ * Tests if an object is a tuple or list.
+ *
+ * @param obj_in [in]  A MicroPython object
+ * @return             True if @p obj_in is a tuple or list, otherwise false.
+*/
+bool pb_obj_is_array(mp_obj_t obj_in) {
+    return mp_obj_is_type(obj_in, &mp_type_tuple) || mp_obj_is_type(obj_in, &mp_type_list);
+}
+
 /**
  * Populates an array of percentages from a single number or tuple.
  *
@@ -134,7 +144,7 @@ mp_int_t pb_obj_get_default_abs_int(mp_obj_t obj, mp_int_t default_val) {
  * Raises exception if @p obj_in is not a number or a tuple of @p num values.
  */
 void pb_obj_get_pct_or_array(mp_obj_t obj_in, size_t num, int8_t *values) {
-    if (mp_obj_is_type(obj_in, &mp_type_tuple) || mp_obj_is_type(obj_in, &mp_type_list)) {
+    if (pb_obj_is_array(obj_in)) {
         mp_obj_t *items;
         size_t len;
         mp_obj_get_array(obj_in, &len, &items);

pybricks/util_mp/pb_obj_helper.h

@@ -30,6 +30,9 @@ mp_obj_t pb_obj_new_fraction(int32_t numerator, int32_t denominator);
 // Get absolute value if object is not none, else return default
 mp_int_t pb_obj_get_default_abs_int(mp_obj_t obj, mp_int_t default_val);
 
+// Tests if an object is a tuple or list
+bool pb_obj_is_array(mp_obj_t obj_in);
+
 // Get array of percentages from single value or tuple
 void pb_obj_get_pct_or_array(mp_obj_t obj_in, size_t num, int8_t *values);