drv/uart: drop return on pbdrv_uart_set_baud_rate()

This is not an async function and we currently don't have a way to
handle any other errors. So removing the return value will reduce
code size. Also, the STM32F0 had a weird check for busy that other
drivers didn't have, so that is removed.

Author: dlech

lib/pbio/drv/uart/uart_stm32f0.c

@@ -166,16 +166,10 @@ void pbdrv_uart_write_cancel(pbdrv_uart_dev_t *uart_dev) {
     uart->tx_result = PBIO_ERROR_CANCELED;
 }
 
-pbio_error_t pbdrv_uart_set_baud_rate(pbdrv_uart_dev_t *uart_dev, uint32_t baud) {
+void pbdrv_uart_set_baud_rate(pbdrv_uart_dev_t *uart_dev, uint32_t baud) {
     pbdrv_uart_t *uart = PBIO_CONTAINER_OF(uart_dev, pbdrv_uart_t, uart_dev);
 
-    if (uart->tx_buf || uart->rx_buf) {
-        return PBIO_ERROR_AGAIN;
-    }
-
     uart->USART->BRR = PBDRV_CONFIG_SYS_CLOCK_RATE / baud;
-
-    return PBIO_SUCCESS;
 }
 
 void pbdrv_uart_flush(pbdrv_uart_dev_t *uart_dev) {

lib/pbio/drv/uart/uart_stm32f4_ll_irq.c

@@ -151,7 +151,7 @@ void pbdrv_uart_write_cancel(pbdrv_uart_dev_t *uart_dev) {
     // TODO
 }
 
-pbio_error_t pbdrv_uart_set_baud_rate(pbdrv_uart_dev_t *uart_dev, uint32_t baud) {
+void pbdrv_uart_set_baud_rate(pbdrv_uart_dev_t *uart_dev, uint32_t baud) {
     pbdrv_uart_t *uart = PBIO_CONTAINER_OF(uart_dev, pbdrv_uart_t, uart_dev);
     USART_TypeDef *USARTx = uart->pdata->uart;
     uint32_t periphclk = LL_RCC_PERIPH_FREQUENCY_NO;
@@ -175,8 +175,6 @@ pbio_error_t pbdrv_uart_set_baud_rate(pbdrv_uart_dev_t *uart_dev, uint32_t baud)
     }
 
     LL_USART_SetBaudRate(USARTx, periphclk, LL_USART_OVERSAMPLING_16, baud);
-
-    return PBIO_SUCCESS;
 }
 
 void pbdrv_uart_flush(pbdrv_uart_dev_t *uart_dev) {

lib/pbio/drv/uart/uart_stm32l4_ll_dma.c

@@ -284,7 +284,7 @@ void pbdrv_uart_write_cancel(pbdrv_uart_dev_t *uart_dev) {
     // TODO
 }
 
-pbio_error_t pbdrv_uart_set_baud_rate(pbdrv_uart_dev_t *uart_dev, uint32_t baud) {
+void pbdrv_uart_set_baud_rate(pbdrv_uart_dev_t *uart_dev, uint32_t baud) {
     pbdrv_uart_t *uart = PBIO_CONTAINER_OF(uart_dev, pbdrv_uart_t, uart_dev);
     USART_TypeDef *USARTx = uart->pdata->uart;
     uint32_t periphclk = LL_RCC_PERIPH_FREQUENCY_NO;
@@ -314,13 +314,11 @@ pbio_error_t pbdrv_uart_set_baud_rate(pbdrv_uart_dev_t *uart_dev, uint32_t baud)
         }
         #endif /* UART5 */
         else {
-            return PBIO_ERROR_FAILED;
+            return;
         }
 
         LL_USART_SetBaudRate(USARTx, periphclk, LL_USART_OVERSAMPLING_16, baud);
     }
-
-    return PBIO_SUCCESS;
 }
 
 void pbdrv_uart_flush(pbdrv_uart_dev_t *uart_dev) {

lib/pbio/include/pbdrv/uart.h

@@ -29,7 +29,7 @@ pbio_error_t pbdrv_uart_get(uint8_t id, pbdrv_uart_dev_t **uart_dev);
  * @param [in]  baud    The baud rate
  * @return              ::PBIO_SUCCESS if the baud rate was set or
  */
-pbio_error_t pbdrv_uart_set_baud_rate(pbdrv_uart_dev_t *uart, uint32_t baud);
+void pbdrv_uart_set_baud_rate(pbdrv_uart_dev_t *uart, uint32_t baud);
 pbio_error_t pbdrv_uart_read_begin(pbdrv_uart_dev_t *uart, uint8_t *msg, uint8_t length, uint32_t timeout);
 pbio_error_t pbdrv_uart_read_end(pbdrv_uart_dev_t *uart);
 void pbdrv_uart_read_cancel(pbdrv_uart_dev_t *uart);
@@ -44,8 +44,7 @@ static inline pbio_error_t pbdrv_uart_get(uint8_t id, pbdrv_uart_dev_t **uart_de
     *uart_dev = NULL;
     return PBIO_ERROR_NOT_SUPPORTED;
 }
-static inline pbio_error_t pbdrv_uart_set_baud_rate(pbdrv_uart_dev_t *uart, uint32_t baud) {
-    return PBIO_ERROR_NOT_SUPPORTED;
+static inline void pbdrv_uart_set_baud_rate(pbdrv_uart_dev_t *uart, uint32_t baud) {
 }
 static inline pbio_error_t pbdrv_uart_read_begin(pbdrv_uart_dev_t *uart, uint8_t *msg, uint8_t length, uint32_t timeout) {
     return PBIO_ERROR_NOT_SUPPORTED;

lib/pbio/src/uartdev.c

@@ -759,7 +759,7 @@ static PT_THREAD(pbio_uartdev_update(uartdev_port_data_t * data)) {
     pbdrv_uart_flush(data->uart);
 
     // Send SPEED command at 115200 baud
-    PBIO_PT_WAIT_READY(&data->pt, pbdrv_uart_set_baud_rate(data->uart, EV3_UART_SPEED_LPF2));
+    pbdrv_uart_set_baud_rate(data->uart, EV3_UART_SPEED_LPF2);
     debug_pr("set baud: %d\n", EV3_UART_SPEED_LPF2);
     PT_SPAWN(&data->pt, &data->speed_pt, pbio_uartdev_send_speed_msg(data, EV3_UART_SPEED_LPF2));
 
@@ -773,7 +773,7 @@ static PT_THREAD(pbio_uartdev_update(uartdev_port_data_t * data)) {
     PBIO_PT_WAIT_READY(&data->pt, err = pbdrv_uart_read_end(data->uart));
     if ((err == PBIO_SUCCESS && data->rx_msg[0] != LUMP_SYS_ACK) || err == PBIO_ERROR_TIMEDOUT) {
         // if we did not get ACK within 100ms, then switch to slow baud rate for sync
-        PBIO_PT_WAIT_READY(&data->pt, pbdrv_uart_set_baud_rate(data->uart, EV3_UART_SPEED_MIN));
+        pbdrv_uart_set_baud_rate(data->uart, EV3_UART_SPEED_MIN);
         debug_pr("set baud: %d\n", EV3_UART_SPEED_MIN);
     } else if (err != PBIO_SUCCESS) {
         DBG_ERR(data->last_err = "UART Rx error during baud");
@@ -902,7 +902,7 @@ static PT_THREAD(pbio_uartdev_update(uartdev_port_data_t * data)) {
     PT_WAIT_UNTIL(&data->pt, etimer_expired(&data->timer));
 
     // change the baud rate
-    PBIO_PT_WAIT_READY(&data->pt, pbdrv_uart_set_baud_rate(data->uart, data->new_baud_rate));
+    pbdrv_uart_set_baud_rate(data->uart, data->new_baud_rate);
     debug_pr("set baud: %" PRIu32 "\n", data->new_baud_rate);
 
     data->status = PBIO_UARTDEV_STATUS_DATA;

lib/pbio/test/src/test_uartdev.c

@@ -993,9 +993,8 @@ pbio_error_t pbdrv_uart_get(uint8_t id, pbdrv_uart_dev_t **uart_dev) {
     return PBIO_SUCCESS;
 }
 
-pbio_error_t pbdrv_uart_set_baud_rate(pbdrv_uart_dev_t *uart, uint32_t baud) {
+void pbdrv_uart_set_baud_rate(pbdrv_uart_dev_t *uart, uint32_t baud) {
     test_uart_dev.baud = baud;
-    return PBIO_SUCCESS;
 }
 
 void pbdrv_uart_flush(pbdrv_uart_dev_t *uart_dev) {