pbio/color: rename PURPLE to VIOLET

In color science, "violet" is usually used for the spectral color name
while "purple" is used to describe pigment color (i.e. dark magenta).

This is a breaking change from Pybricks v2.0.

Issue: pybricks/support#95 (comment)

Author: dlech

bricks/ev3dev/pb_type_ev3dev_image.c

@@ -72,8 +72,8 @@ STATIC GrxColor map_color(mp_obj_t *obj) {
             return grx_color_get(165, 42, 42);
         case PBIO_COLOR_ORANGE:
             return grx_color_get(255, 165, 0);
-        case PBIO_COLOR_PURPLE:
-            return grx_color_get(128, 0, 128);
+        case PBIO_COLOR_VIOLET:
+            return grx_color_get(238, 130, 238);
     }
     return grx_color_get_black();
 }

lib/pbio/include/pbio/color.h

@@ -44,7 +44,7 @@ typedef enum {
     PBIO_COLOR_GREEN = PBIO_COLOR_ENCODE(120, 100, 100), /**< green */
     PBIO_COLOR_CYAN = PBIO_COLOR_ENCODE(180, 100, 100), /**< cyan */
     PBIO_COLOR_BLUE = PBIO_COLOR_ENCODE(240, 100, 100), /**< blue */
-    PBIO_COLOR_PURPLE = PBIO_COLOR_ENCODE(270, 100, 100), /**< purple */
+    PBIO_COLOR_VIOLET = PBIO_COLOR_ENCODE(270, 100, 100), /**< violet */
     PBIO_COLOR_MAGENTA = PBIO_COLOR_ENCODE(300, 100, 100), /**< magenta */
 } pbio_color_t;
 

lib/pbio/test/color.c

@@ -255,7 +255,7 @@ void test_color_to_hsv(void *env) {
     tt_want_int_op(hsv.s, ==, 100);
     tt_want_int_op(hsv.v, ==, 100);
 
-    pbio_color_to_hsv(PBIO_COLOR_PURPLE, &hsv);
+    pbio_color_to_hsv(PBIO_COLOR_VIOLET, &hsv);
     tt_want_int_op(hsv.h, ==, 270);
     tt_want_int_op(hsv.s, ==, 100);
     tt_want_int_op(hsv.v, ==, 100);

pybricks/parameters.h

@@ -39,7 +39,7 @@ const pb_obj_enum_member_t pb_Button_BEACON_obj;
 const mp_obj_type_t pb_enum_type_Color;
 
 const pb_obj_enum_member_t pb_Color_BLACK_obj;
-const pb_obj_enum_member_t pb_Color_PURPLE_obj;
+const pb_obj_enum_member_t pb_Color_VIOLET_obj;
 const pb_obj_enum_member_t pb_Color_BLUE_obj;
 const pb_obj_enum_member_t pb_Color_GREEN_obj;
 const pb_obj_enum_member_t pb_Color_YELLOW_obj;
@@ -52,7 +52,7 @@ const pb_obj_enum_member_t pb_Color_CYAN_obj;
 const pb_obj_enum_member_t pb_Color_MAGENTA_obj;
 
 #define pb_const_color_black    MP_OBJ_FROM_PTR(&pb_Color_BLACK_obj)
-#define pb_const_color_purple   MP_OBJ_FROM_PTR(&pb_Color_PURPLE_obj)
+#define pb_const_color_purple   MP_OBJ_FROM_PTR(&pb_Color_VIOLET_obj)
 #define pb_const_color_blue     MP_OBJ_FROM_PTR(&pb_Color_BLUE_obj)
 #define pb_const_color_green    MP_OBJ_FROM_PTR(&pb_Color_GREEN_obj)
 #define pb_const_color_yellow   MP_OBJ_FROM_PTR(&pb_Color_YELLOW_obj)

pybricks/parameters/pb_type_color.c

@@ -17,10 +17,10 @@ const pb_obj_enum_member_t pb_Color_BLACK_obj = {
     .value = PBIO_COLOR_BLACK
 };
 
-const pb_obj_enum_member_t pb_Color_PURPLE_obj = {
+const pb_obj_enum_member_t pb_Color_VIOLET_obj = {
     {&pb_enum_type_Color},
-    .name = MP_QSTR_PURPLE,
-    .value = PBIO_COLOR_PURPLE
+    .name = MP_QSTR_VIOLET,
+    .value = PBIO_COLOR_VIOLET
 };
 
 const pb_obj_enum_member_t pb_Color_BLUE_obj = {
@@ -85,7 +85,7 @@ const pb_obj_enum_member_t pb_Color_MAGENTA_obj = {
 
 STATIC const mp_rom_map_elem_t pb_enum_Color_table[] = {
     { MP_ROM_QSTR(MP_QSTR_BLACK),   MP_ROM_PTR(&pb_Color_BLACK_obj)  },
-    { MP_ROM_QSTR(MP_QSTR_PURPLE),  MP_ROM_PTR(&pb_Color_PURPLE_obj) },
+    { MP_ROM_QSTR(MP_QSTR_VIOLET),  MP_ROM_PTR(&pb_Color_VIOLET_obj) },
     { MP_ROM_QSTR(MP_QSTR_BLUE),    MP_ROM_PTR(&pb_Color_BLUE_obj)   },
     { MP_ROM_QSTR(MP_QSTR_GREEN),   MP_ROM_PTR(&pb_Color_GREEN_obj)  },
     { MP_ROM_QSTR(MP_QSTR_YELLOW),  MP_ROM_PTR(&pb_Color_YELLOW_obj) },