pbio/iodev: Drop num_view_modes.

This is not used anywhere, and it isn't very useful information, so we can delete it. It might tell us that some modes are not worth using, but not which ones.

Author: laurensvalk

lib/pbio/include/pbio/iodev.h

@@ -286,12 +286,6 @@ typedef struct {
      * The number of modes the device has. (Indicates size of *mode_info*).
      */
     uint8_t num_modes;
-    /**
-     * The number of "view" modes the device has. This modes are show in the
-     * port monitor. Other modes may or may not be useable depending on the
-     * device (e.g. some are for factory calibration).
-     */
-    uint8_t num_view_modes;
     /**
      * Bit flags indicating which combination of modes can be used at the same
      * time. Each bit cooresponds to the mode of the same number (0 to 15).

lib/pbio/src/uartdev.c

@@ -359,15 +359,9 @@ static void pbio_uartdev_parse_msg(uartdev_port_data_t *data) {
                         // Powered Up devices can have an extended mode message that
                         // includes modes > LUMP_MAX_MODE
                         data->info->num_modes = data->rx_msg[3] + 1;
-                        data->info->num_view_modes = data->rx_msg[4] + 1;
-                    } else if (msg_size > 3) {
-                        data->info->num_view_modes = data->rx_msg[2] + 1;
-                    } else {
-                        data->info->num_view_modes = data->info->num_modes;
                     }
 
                     debug_pr("num_modes: %d\n", data->info->num_modes);
-                    debug_pr("num_view_modes: %d\n", data->info->num_view_modes);
 
                     break;
                 case LUMP_CMD_SPEED:
@@ -816,7 +810,6 @@ static PT_THREAD(pbio_uartdev_update(uartdev_port_data_t * data)) {
     // if all was good, we are ready to start receiving the mode info
 
     data->info->num_modes = 1;
-    data->info->num_view_modes = 1;
 
     data->type_id = data->rx_msg[1];
     data->info_flags = EV3_UART_INFO_FLAG_CMD_TYPE;

lib/pbio/test/src/uartdev.c

@@ -354,7 +354,6 @@ static PT_THREAD(test_boost_color_distance_sensor(struct pt *pt)) {
     tt_uint_op(pbio_uartdev_get(0, &iodev), ==, PBIO_SUCCESS);
     tt_want_uint_op(iodev->info->type_id, ==, PBIO_IODEV_TYPE_ID_COLOR_DIST_SENSOR);
     tt_want_uint_op(iodev->info->num_modes, ==, 11);
-    tt_want_uint_op(iodev->info->num_view_modes, ==, 8);
     // TODO: verify fw/hw versions
     tt_want_uint_op(iodev->info->mode_combos, ==, 1 << 6 | 1 << 3 | 1 << 2 | 1 << 1 | 1 << 0);
     tt_want_uint_op(iodev->info->capability_flags, ==, PBIO_IODEV_CAPABILITY_FLAG_NONE);
@@ -600,7 +599,6 @@ static PT_THREAD(test_boost_interactive_motor(struct pt *pt)) {
     tt_uint_op(pbio_uartdev_get(0, &iodev), ==, PBIO_SUCCESS);
     tt_want_uint_op(iodev->info->type_id, ==, PBIO_IODEV_TYPE_ID_INTERACTIVE_MOTOR);
     tt_want_uint_op(iodev->info->num_modes, ==, 4);
-    tt_want_uint_op(iodev->info->num_view_modes, ==, 3);
     // TODO: verify fw/hw versions
     tt_want_uint_op(iodev->info->mode_combos, ==, 1 << 2 | 1 << 1);
     tt_want_uint_op(iodev->info->capability_flags, ==, PBIO_IODEV_CAPABILITY_FLAG_IS_MOTOR |
@@ -803,7 +801,6 @@ static PT_THREAD(test_technic_large_motor(struct pt *pt)) {
     tt_uint_op(pbio_uartdev_get(0, &iodev), ==, PBIO_SUCCESS);
     tt_want_uint_op(iodev->info->type_id, ==, PBIO_IODEV_TYPE_ID_TECHNIC_L_MOTOR);
     tt_want_uint_op(iodev->info->num_modes, ==, 6);
-    tt_want_uint_op(iodev->info->num_view_modes, ==, 4);
     // TODO: verify fw/hw versions
     tt_want_uint_op(iodev->info->mode_combos, ==, 1 << 3 | 1 << 2 | 1 << 1);
     tt_want_uint_op(iodev->info->capability_flags, ==, PBIO_IODEV_CAPABILITY_FLAG_IS_MOTOR | PBIO_IODEV_CAPABILITY_FLAG_HAS_MOTOR_SPEED
@@ -1012,7 +1009,6 @@ static PT_THREAD(test_technic_xl_motor(struct pt *pt)) {
     tt_uint_op(pbio_uartdev_get(0, &iodev), ==, PBIO_SUCCESS);
     tt_want_uint_op(iodev->info->type_id, ==, PBIO_IODEV_TYPE_ID_TECHNIC_XL_MOTOR);
     tt_want_uint_op(iodev->info->num_modes, ==, 6);
-    tt_want_uint_op(iodev->info->num_view_modes, ==, 4);
     // TODO: verify fw/hw versions
     tt_want_uint_op(iodev->info->mode_combos, ==, 1 << 3 | 1 << 2 | 1 << 1);
     tt_want_uint_op(iodev->info->capability_flags, ==, PBIO_IODEV_CAPABILITY_FLAG_IS_MOTOR | PBIO_IODEV_CAPABILITY_FLAG_HAS_MOTOR_SPEED