platform/cplus: don't invert LED PWMs

This removes the inversion on the LED PWM channels. This way we don't
have to compute the inverse when setting the PWM duty cycle.

Also divide by 256 instead of 255 to further reduce firmware size.

Author: dlech

lib/pbio/drv/cplus_hub/light.c

@@ -21,13 +21,13 @@ pbio_error_t pbdrv_light_set_rgb(pbio_port_t port, const pbdrv_light_raw_rgb_t *
 
     pbdrv_pwm_dev_t *dev;
     if (pbdrv_pwm_get_dev(1, &dev) == PBIO_SUCCESS) {
-        pbdrv_pwm_set_duty(dev, 2, 10000 - raw->r * 2000 / 255);
+        pbdrv_pwm_set_duty(dev, 2, raw->r * 2000 / 256);
     }
     if (pbdrv_pwm_get_dev(0, &dev) == PBIO_SUCCESS) {
-        pbdrv_pwm_set_duty(dev, 4, 10000 - raw->g * 2000 / 255);
+        pbdrv_pwm_set_duty(dev, 4, raw->g * 2000 / 256);
     }
     if (pbdrv_pwm_get_dev(2, &dev) == PBIO_SUCCESS) {
-        pbdrv_pwm_set_duty(dev, 1, 10000 - raw->b * 2000 / 255);
+        pbdrv_pwm_set_duty(dev, 1, raw->b * 2000 / 256);
     }
 
     return PBIO_SUCCESS;

lib/pbio/platform/cplus_hub/platform.c

@@ -103,7 +103,7 @@ const pbdrv_pwm_stm32_tim_platform_data_t
         .channels = PBDRV_PWM_STM32_TIM_CHANNEL_1_ENABLE | PBDRV_PWM_STM32_TIM_CHANNEL_2_ENABLE
             | PBDRV_PWM_STM32_TIM_CHANNEL_3_ENABLE | PBDRV_PWM_STM32_TIM_CHANNEL_4_ENABLE
             | PBDRV_PWM_STM32_TIM_CHANNEL_1_INVERT | PBDRV_PWM_STM32_TIM_CHANNEL_2_INVERT
-            | PBDRV_PWM_STM32_TIM_CHANNEL_3_INVERT | PBDRV_PWM_STM32_TIM_CHANNEL_4_INVERT
+            | PBDRV_PWM_STM32_TIM_CHANNEL_3_INVERT
             | PBDRV_PWM_STM32_TIM_CHANNEL_1_COMPLEMENT | PBDRV_PWM_STM32_TIM_CHANNEL_2_COMPLEMENT
             | PBDRV_PWM_STM32_TIM_CHANNEL_3_COMPLEMENT,
     },
@@ -114,16 +114,15 @@ const pbdrv_pwm_stm32_tim_platform_data_t
         .period = 10000, // 12MHz divided by 10k makes 1 kHz PWM
         .id = PWM_DEV_1,
         .channels = PBDRV_PWM_STM32_TIM_CHANNEL_1_ENABLE | PBDRV_PWM_STM32_TIM_CHANNEL_2_ENABLE
-            | PBDRV_PWM_STM32_TIM_CHANNEL_1_INVERT | PBDRV_PWM_STM32_TIM_CHANNEL_2_INVERT
-            | PBDRV_PWM_STM32_TIM_CHANNEL_1_COMPLEMENT,
+            | PBDRV_PWM_STM32_TIM_CHANNEL_1_INVERT | PBDRV_PWM_STM32_TIM_CHANNEL_1_COMPLEMENT,
     },
     {
         .platform_init = pwm_dev_2_platform_init,
         .TIMx = TIM16,
         .prescalar = 8, // results in 10 MHz clock
         .period = 10000, // 12MHz divided by 10k makes 1 kHz PWM
         .id = PWM_DEV_2,
-        .channels = PBDRV_PWM_STM32_TIM_CHANNEL_1_ENABLE | PBDRV_PWM_STM32_TIM_CHANNEL_1_INVERT,
+        .channels = PBDRV_PWM_STM32_TIM_CHANNEL_1_ENABLE,
     },
 };