pybricks.iodevices.XboxController: Add dpad as buttons.

Fixes https://github.com/orgs/pybricks/discussions/1537

Author: laurensvalk

CHANGELOG.md

@@ -6,11 +6,15 @@
 
 ### Added
 - Added support for rumble in `XboxController` ([support#1024]).
+- Added `Button.UP`, `Button.DOWN`, `Button.LEFT`, and `Button.RIGHT` to
+  `XboxController` buttons method ([support#1537]). The separate directional
+  pad method remains available.
 
 ### Changed
 - Allow single floating point value for brightness array ([support#1547]).
 
 [support#1024]: https://github.com/pybricks/support/issues/1024
+[support#1537]: https://github.com/orgs/pybricks/discussions/1537
 [support#1547]: https://github.com/pybricks/support/issues/1547
 
 ## [3.4.0] - 2024-03-11

pybricks/iodevices/pb_type_iodevices_xbox_controller.c

@@ -193,7 +193,8 @@ STATIC xbox_input_map_t *pb_xbox_get_buttons(void) {
 STATIC mp_obj_t pb_xbox_button_pressed(void) {
     xbox_input_map_t *buttons = pb_xbox_get_buttons();
 
-    mp_obj_t items[16];
+    // At most 16 simultaneous button presses, plus up to two dpad directions.
+    mp_obj_t items[16 + 2];
     size_t count = 0;
 
     if (buttons->buttons & 1) {
@@ -245,6 +246,30 @@ STATIC mp_obj_t pb_xbox_button_pressed(void) {
         items[count++] = pb_type_button_new(MP_QSTR_P4);
     }
 
+    // Dpad is available as separate method, but can also be used as
+    // a normal set of buttons.
+    if (buttons->dpad == 1) {
+        items[count++] = pb_type_button_new(MP_QSTR_UP);
+    } else if (buttons->dpad == 2) {
+        items[count++] = pb_type_button_new(MP_QSTR_UP);
+        items[count++] = pb_type_button_new(MP_QSTR_RIGHT);
+    } else if (buttons->dpad == 3) {
+        items[count++] = pb_type_button_new(MP_QSTR_RIGHT);
+    } else if (buttons->dpad == 4) {
+        items[count++] = pb_type_button_new(MP_QSTR_RIGHT);
+        items[count++] = pb_type_button_new(MP_QSTR_DOWN);
+    } else if (buttons->dpad == 5) {
+        items[count++] = pb_type_button_new(MP_QSTR_DOWN);
+    } else if (buttons->dpad == 6) {
+        items[count++] = pb_type_button_new(MP_QSTR_DOWN);
+        items[count++] = pb_type_button_new(MP_QSTR_LEFT);
+    } else if (buttons->dpad == 7) {
+        items[count++] = pb_type_button_new(MP_QSTR_LEFT);
+    } else if (buttons->dpad == 8) {
+        items[count++] = pb_type_button_new(MP_QSTR_LEFT);
+        items[count++] = pb_type_button_new(MP_QSTR_UP);
+    }
+
     return mp_obj_new_set(count, items);
 }