tree-wide: fix compiler type warnings

Upstream micropython has enabled a few more compiler warnings to detect
implicit casting. This fixes those errors.

Author: dlech

extmod/modbuiltins.c

@@ -107,7 +107,7 @@ STATIC mp_obj_t builtins_LightArray_on(size_t n_args, const mp_obj_t *pos_args,
     builtins_LightArray_obj_t *self = MP_OBJ_TO_PTR(pos_args[0]);
 
     // We may either have one brightness or all brightness values
-    if (!(n_args == 2 || n_args == self->number_of_lights + 1)) {
+    if (!(n_args == 2 || n_args == (size_t)self->number_of_lights + 1)) {
         pb_assert(PBIO_ERROR_INVALID_ARG);
     }
 

extmod/modev3devices.c

@@ -316,9 +316,9 @@ STATIC mp_obj_t ev3devices_ColorSensor_rgb(mp_obj_t self_in) {
     pbdevice_get_values(self->pbdev, PBIO_IODEV_MODE_EV3_COLOR_SENSOR__RGB_RAW, rgb);
     mp_obj_t tup[3];
 
-    rgb[0] = (0.258 * rgb[0]) - 0.3;
-    rgb[1] = (0.280 * rgb[1]) - 0.8;
-    rgb[2] = (0.523 * rgb[2]) - 3.7;
+    rgb[0] = (int)((0.258 * rgb[0]) - 0.3);
+    rgb[1] = (int)((0.280 * rgb[1]) - 0.8);
+    rgb[2] = (int)((0.523 * rgb[2]) - 3.7);
 
     for (uint8_t i = 0; i < 3; i++) {
         rgb[i] = (rgb[i] > 100 ? 100 : rgb[i]);

extmod/modmotor.c

@@ -193,7 +193,7 @@ STATIC mp_obj_t motor_Motor_make_new(const mp_obj_type_t *type, size_t n_args, s
         }
 
         // Iterate through each of the n_trains lists
-        for (int16_t train = 0; train < n_trains; train++) {
+        for (size_t train = 0; train < n_trains; train++) {
             // Unless we have just one list of gears, unpack the list of gears for this train
             if (!is_one_train) {
                 mp_obj_get_array(trains[train], &n_gears, &gear_list);

lib/ev3dev/src/ev3dev_stretch/lego_port.c

@@ -81,7 +81,7 @@ static pbio_error_t ev3dev_lego_port_get_mode(pbio_port_t port, const char *attr
     }
 
     // Find matching port mode string
-    for (int i = 0; i < PBIO_ARRAY_SIZE(port_modes); i++) {
+    for (size_t i = 0; i < PBIO_ARRAY_SIZE(port_modes); i++) {
         if (!strcmp(mode, port_modes[i])) {
             *port_mode = i;
             return PBIO_SUCCESS;
@@ -110,7 +110,7 @@ static pbio_error_t ev3dev_lego_port_set_mode(pbio_port_t port, ev3dev_lego_port
         return PBIO_ERROR_IO;
     }
     // Write mode
-    if (fprintf(f_port_mode, "%s", port_modes[mode]) != strlen(port_modes[mode])) {
+    if (fprintf(f_port_mode, "%s", port_modes[mode]) != (int)strlen(port_modes[mode])) {
         return PBIO_ERROR_IO;
     }
     // Close the mode file
@@ -122,7 +122,6 @@ static pbio_error_t ev3dev_lego_port_set_mode(pbio_port_t port, ev3dev_lego_port
 
 // Set compatible port configuration for given device
 pbio_error_t ev3dev_lego_port_configure(pbio_port_t port, pbio_iodev_type_id_t id) {
-    
     pbio_error_t err;
 
     // Get the current port mode and status

lib/ev3dev/src/ev3dev_stretch/lego_sensor.c

@@ -254,7 +254,7 @@ pbio_error_t lego_sensor_get_info(lego_sensor_t *sensor, uint8_t *data_len, lego
 pbio_error_t lego_sensor_get_mode_id_from_str(lego_sensor_t *sensor, const char *mode_str, uint8_t *mode) {
 
     // Find matching port mode string
-    for (int i = 0; i < PBIO_ARRAY_SIZE(sensor->modes); i++) {
+    for (size_t i = 0; i < PBIO_ARRAY_SIZE(sensor->modes); i++) {
         if (!strcmp(mode_str, sensor->modes[i])) {
             *mode = i;
             return PBIO_SUCCESS;

lib/ev3dev/src/ev3dev_stretch/nxtcolor.c

@@ -151,7 +151,7 @@ static pbio_error_t nxtcolor_get_digi1(nxtcolor_t *nxtcolor, bool *val) {
     return PBIO_SUCCESS;
 }
 
-static pbio_error_t nxtcolor_get_adc(nxtcolor_t *nxtcolor, int32_t *analog) {
+static pbio_error_t nxtcolor_get_adc(nxtcolor_t *nxtcolor, uint32_t *analog) {
 
     pbio_error_t err;
 
@@ -164,7 +164,7 @@ static pbio_error_t nxtcolor_get_adc(nxtcolor_t *nxtcolor, int32_t *analog) {
         nxtcolor->digi1_dir = IN;
     }
     // Get the state
-    return sysfs_read_int(nxtcolor->f_adc_val, analog);
+    return sysfs_read_int(nxtcolor->f_adc_val, (int *)analog);
 }
 
 static pbio_error_t nxtcolor_reset(nxtcolor_t *nxtcolor)
@@ -482,7 +482,7 @@ pbio_error_t nxtcolor_get_values_at_mode(pbio_port_t port, uint8_t mode, int32_t
     }
 
     // In measure mode, cycle through the colors and calculate color id
-    int32_t rgba[4];
+    uint32_t rgba[4];
 
     // Read analog for each color
     for (uint8_t i = 0; i < 4; i++) {

lib/ev3dev/src/ev3dev_stretch/sysfs.c

@@ -112,7 +112,7 @@ pbio_error_t sysfs_write_str(FILE *file, const char *str) {
         return PBIO_ERROR_IO;
     }
 
-    if (fprintf(file, "%s", str) != strlen(str)) {
+    if (fprintf(file, "%s", str) != (int)strlen(str)) {
         return PBIO_ERROR_IO;
     }
 

lib/pbio/drv/counter/counter_ev3dev_stretch_iio.c

@@ -110,10 +110,10 @@ static pbio_error_t counter_ev3dev_stretch_iio_init() {
     }
 
 
-    for (int i = 0; i < PBIO_ARRAY_SIZE(private_data); i++) {
+    for (size_t i = 0; i < PBIO_ARRAY_SIZE(private_data); i++) {
         private_data_t *data = &private_data[i];
 
-        snprintf(buf, sizeof(buf), "%s/in_count%d_raw", udev_list_entry_get_name(entry), i);
+        snprintf(buf, sizeof(buf), "%s/in_count%d_raw", udev_list_entry_get_name(entry), (int)i);
         data->count = fopen(buf, "r");
         if (!data->count) {
             dbg_err("failed to open count attribute");
@@ -122,7 +122,7 @@ static pbio_error_t counter_ev3dev_stretch_iio_init() {
 
         setbuf(data->count, NULL);
 
-        snprintf(buf, sizeof(buf), "%s/in_frequency%d_input", udev_list_entry_get_name(entry), i);
+        snprintf(buf, sizeof(buf), "%s/in_frequency%d_input", udev_list_entry_get_name(entry), (int)i);
         data->rate = fopen(buf, "r");
         if (!data->rate) {
             dbg_err("failed to open rate attribute");
@@ -151,7 +151,7 @@ static pbio_error_t counter_ev3dev_stretch_iio_init() {
 }
 
 static pbio_error_t counter_ev3dev_stretch_iio_exit() {
-    for (int i = 0; i < PBIO_ARRAY_SIZE(private_data); i++) {
+    for (size_t i = 0; i < PBIO_ARRAY_SIZE(private_data); i++) {
         private_data_t *data = &private_data[i];
 
         data->dev.initalized = false;

lib/pbio/drv/ev3dev_stretch/serial.c

@@ -167,7 +167,7 @@ pbio_error_t pbdrv_serial_get(pbdrv_serial_t **_ser, pbio_port_t port, int baudr
 }
 
 pbio_error_t pbdrv_serial_write(pbdrv_serial_t *ser, const void *buf, size_t count) {
-    if (write(ser->file, buf, count) != count) {
+    if (write(ser->file, buf, count) != (int)count) {
         return PBIO_ERROR_IO;
     }
     return PBIO_SUCCESS;

lib/pbio/include/pbio/serial.h

@@ -12,7 +12,7 @@ typedef struct _pbio_serial_t pbio_serial_t;
 
 #if PBIO_CONFIG_SERIAL
 
-pbio_error_t pbio_serial_get(pbio_serial_t **_ser, pbio_port_t port, int baudrate, int timeout);
+pbio_error_t pbio_serial_get(pbio_serial_t **_ser, pbio_port_t port, uint32_t baudrate, int32_t timeout);
 
 pbio_error_t pbio_serial_write(pbio_serial_t *ser, const void *buf, size_t count);
 
@@ -24,7 +24,7 @@ pbio_error_t pbio_serial_clear(pbio_serial_t *ser);
 
 #else // PBIO_CONFIG_SERIAL
 
-static inline pbio_error_t pbio_serial_get(pbio_serial_t **_ser, pbio_port_t port, int baudrate, int timeout) {
+static inline pbio_error_t pbio_serial_get(pbio_serial_t **_ser, pbio_port_t port, uint32_t baudrate, int32_t timeout) {
     return PBIO_ERROR_NOT_SUPPORTED;
 }
 static inline pbio_error_t pbio_serial_write(pbio_serial_t *ser, const void *buf, size_t count) {