src/lightgrid: remove unnecessary cast

dlech · dlech · commit baec561adb99 · 2020-08-20T17:05:27.000-05:00
In C, anything smaller than int is promoted to int for math ops.
diff --git a/lib/pbio/src/lightgrid.c b/lib/pbio/src/lightgrid.c
@@ -83,7 +83,7 @@ pbio_error_t pbio_lightgrid_set_pixel(pbio_lightgrid_t *lightgrid, uint8_t row,
     }
 
     // Scale brightness quadratically from 0 to UINT16_MAX
-    int32_t duty = ((int32_t)brightness) * brightness * UINT16_MAX / 10000;
+    int32_t duty = brightness * brightness * UINT16_MAX / 10000;
 
     return pbdrv_pwm_set_duty(lightgrid->pwm, lightgrid->data->channels[row * size + col], duty);
 }

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ pbio_error_t pbio_lightgrid_set_pixel(pbio_lightgrid_t *lightgrid, uint8_t row,`
`83`	`83`	`}`
`84`	`84`
`85`	`85`	`// Scale brightness quadratically from 0 to UINT16_MAX`
`86`		`- int32_t duty = ((int32_t)brightness) * brightness * UINT16_MAX / 10000;`
	`86`	`+ int32_t duty = brightness * brightness * UINT16_MAX / 10000;`
`87`	`87`
`88`	`88`	`return pbdrv_pwm_set_duty(lightgrid->pwm, lightgrid->data->channels[row * size + col], duty);`
`89`	`89`	`}`