npm/firmware: drop default fallback in encodeHubName()

Technically, and empty name is valid according to the Bluetooth spec
and the firmware already includes a default that might not be this, so
it best to handle the empty string case before calling this function
if we want the empty string to mean "use the default value".

Author: dlech

npm/firmware/CHANGELOG.md

@@ -1,4 +1,8 @@
 
+## Unreleased
+### Changed
+- Dropped fallback to default name in `encodeHubName()` on empty string.
+
 ## 4.13.0-rc.1 - 2021-11-19
 ### Added
 - Added support for v1.1.0 metadata.

npm/firmware/index.test.ts

@@ -94,12 +94,9 @@ test('reading data works', async () => {
 describe('firmware name encoder', () => {
     const metadata = { 'max-hub-name-size': 16 } as FirmwareMetadata;
 
-    test('default works', () => {
+    test('empty name works', () => {
         expect(encodeHubName('', metadata)).toEqual(
-            new Uint8Array([
-                80, 121, 98, 114, 105, 99, 107, 115, 32, 72, 117, 98, 0, 0, 0,
-                0,
-            ])
+            new Uint8Array([0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0])
         );
     });
 

npm/firmware/index.ts

@@ -246,11 +246,6 @@ export function encodeHubName(
         throw new Error('firmware image does not support firmware name');
     }
 
-    // fall back to default on empty name
-    if (!name) {
-        name = 'Pybricks Hub';
-    }
-
     const bytes = new Uint8Array(metadata['max-hub-name-size']);
 
     // subarray ensures zero termination if encoded length is >= 'max-hub-name-size'.