pbio/platform/ev3/exceptionhandler.S: Fix bug in panic handler #371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bic opcode was supposed to be used here in order to *clear* the mode bits, rather than keep them. This bug did not surface because we've mostly been hitting panics in System mode, which has a mode bits value of all 1s.
dlech
reviewed
Aug 6, 2025
| mrs r0, spsr | ||
| stmfd sp!, {r0} | ||
| @ Switch to previous mode to read its sp/lr | ||
| @ NOTE: Assumes we never use User mode |
Collaborator
Author
There was a problem hiding this comment.
Yes, you have to do special handling for User mode, since you can't switch into it and switch back out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bic opcode was supposed to be used here in order to clear the mode bits, rather than keep them.
This bug did not surface because we've mostly been hitting panics in System mode, which has a mode bits value of all 1s.