pbdrv/uart: const correctness for write buffer arg #403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlech
reviewed
Oct 21, 2025
Member
dlech
left a comment
dlech
left a comment
There was a problem hiding this comment.
Looks good to me. I just noticed some unrelated things that could also be cleaned up in the ev3_pru header.
We don't need to be able to edit the write buffer in any UART implementation. Making it const prevents some unnecesary casts in upcoming ev3 btstack uart block implementation.
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to be able to edit the write buffer in any UART implementation.
Making it const prevents some unneccesary casts in upcoming ev3 btstack uart
block implementation.